Skip to content

Commit ad58541

Browse files
Copilotbcantoni
andauthored
Fix inspect connection sample review comments
Co-authored-by: bcantoni <58372+bcantoni@users.noreply.github.com>
1 parent 09c9ee5 commit ad58541

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

‎samples/inspect_connection_details.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
# with the community `tableaudocumentapi` library to reach the extra attributes.
1111
#
1212
# Requires:
13-
# pip install tableauserverclient tableau-document-api
13+
# pip install tableauserverclient tableaudocumentapi
1414
#
1515
# Related GitHub issues:
1616
# - server-client-python#1807 (Oracle service on ConnectionItem)
@@ -33,7 +33,7 @@
3333
from tableaudocumentapi import Datasource, Workbook
3434
except ImportError:
3535
raise SystemExit(
36-
"This sample requires the tableau-document-api package.\n" "Install it with: pip install tableau-document-api"
36+
"This sample requires the tableaudocumentapi package.\n" "Install it with: pip install tableaudocumentapi"
3737
)
3838

3939

@@ -55,13 +55,13 @@ def dump_connections_from_workbook_file(path):
5555

5656
def _print_connection(label, c):
5757
print(f"--- {label} ---")
58-
# Every attribute below comes from the raw XML embedded in the file; none of
59-
# these are exposed by TSC's ConnectionItem today.
6058
print(f" dbclass: {c.dbclass}")
6159
print(f" server: {c.server}")
6260
print(f" port: {c.port}")
6361
print(f" username: {c.username}")
6462
print(f" dbname: {c.dbname}")
63+
# Schema, service, query-band, and initial-SQL fields are connector-specific
64+
# and are not exposed by TSC's ConnectionItem today.
6565
print(f" schema: {c.schema}")
6666
print(f" service: {c.service}")
6767
print(f" authentication: {c.authentication}")

0 commit comments

Comments
 (0)