Remove deprecated cgi module and clean up related dead code (#1771)

* Remove deprecated cgi module usage and clean up dead code

Agent-Logs-Url: https://github.com/tableau/server-client-python/sessions/453f920c-7857-4503-ad99-0ccef076d792

Co-authored-by: jacalata <2009720+jacalata@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jacalata <2009720+jacalata@users.noreply.github.com>
Co-authored-by: Brian Cantoni <bcantoni@salesforce.com>

Author: 3 people

tableauserverclient/helpers/headers.py

@@ -9,7 +9,6 @@
 from typing import Literal, Optional, TYPE_CHECKING, TypedDict, TypeVar, Union, overload
 from collections.abc import Iterable, Sequence
 
-from tableauserverclient.helpers.headers import fix_filename
 from tableauserverclient.models.dqw_item import DQWItem
 from tableauserverclient.server.query import QuerySet
 
@@ -1029,14 +1028,13 @@ def download_revision(
         with closing(self.get_request(url, parameters={"stream": True})) as server_response:
             m = Message()
             m["Content-Disposition"] = server_response.headers["Content-Disposition"]
-            params = m.get_filename(failobj="")
+            filename = m.get_filename(failobj="")
             if isinstance(filepath, io_types_w):
                 for chunk in server_response.iter_content(1024):  # 1KB
                     filepath.write(chunk)
                 return_path = filepath
             else:
-                params = fix_filename(params)
-                filename = to_filename(os.path.basename(params))
+                filename = to_filename(os.path.basename(filename))
                 download_path = make_download_path(filepath, filename)
                 with open(download_path, "wb") as f:
                     for chunk in server_response.iter_content(1024):  # 1KB

tableauserverclient/server/endpoint/datasources_endpoint.py

@@ -8,8 +8,6 @@
 from typing import Optional, TYPE_CHECKING, Union
 from collections.abc import Iterable
 
-from tableauserverclient.helpers.headers import fix_filename
-
 from tableauserverclient.server.endpoint.dqw_endpoint import _DataQualityWarningEndpoint
 from tableauserverclient.server.endpoint.endpoint import QuerysetEndpoint, api
 from tableauserverclient.server.endpoint.exceptions import InternalServerError, MissingRequiredFieldError
@@ -227,14 +225,13 @@ def download(self, flow_id: str, filepath: Optional[PathOrFileW] = None) -> Path
         with closing(self.get_request(url, parameters={"stream": True})) as server_response:
             m = Message()
             m["Content-Disposition"] = server_response.headers["Content-Disposition"]
-            params = m.get_filename(failobj="")
+            filename = m.get_filename(failobj="")
             if isinstance(filepath, io_types_w):
                 for chunk in server_response.iter_content(1024):  # 1KB
                     filepath.write(chunk)
                 return_path = filepath
             else:
-                params = fix_filename(params)
-                filename = to_filename(os.path.basename(params))
+                filename = to_filename(os.path.basename(filename))
                 download_path = make_download_path(filepath, filename)
                 with open(download_path, "wb") as f:
                     for chunk in server_response.iter_content(1024):  # 1KB

tableauserverclient/server/endpoint/flows_endpoint.py

@@ -6,7 +6,6 @@
 from contextlib import closing
 from pathlib import Path
 
-from tableauserverclient.helpers.headers import fix_filename
 from tableauserverclient.models.permissions_item import PermissionsRule
 from tableauserverclient.server.query import QuerySet
 
@@ -1102,14 +1101,13 @@ def download_revision(
         with closing(self.get_request(url, parameters={"stream": True})) as server_response:
             m = Message()
             m["Content-Disposition"] = server_response.headers["Content-Disposition"]
-            params = m.get_filename(failobj="")
+            filename = m.get_filename(failobj="")
             if isinstance(filepath, io_types_w):
                 for chunk in server_response.iter_content(1024):  # 1KB
                     filepath.write(chunk)
                 return_path = filepath
             else:
-                params = fix_filename(params)
-                filename = to_filename(os.path.basename(params))
+                filename = to_filename(os.path.basename(filename))
                 download_path = make_download_path(filepath, filename)
                 with open(download_path, "wb") as f:
                     for chunk in server_response.iter_content(1024):  # 1KB