Hi! I've been self-hosting OpenMU with the open-source MuMain client and found a few bugs while testing PvP and general gameplay. Happy to submit PRs if any of these are useful.
1. Soul Barrier / Mana Shield damage overflow
File: AttackableExtensions.cs line 242
When SoulBarrierReceiveDecrement exceeds 1.0, the damage reduction calculation produces negative values that overflow to massive positive numbers (~4 billion damage). Players with Mana Shield active take MORE damage instead of less.
Fix: Clamp the reduction value to 0-0.9 and ensure damage never goes below 0.
2. Area Skill extraTarget bypasses AreaSkillHitsPlayer check
File: AreaSkillAttackAction.cs ~line 108
When a player casts an AoE skill (Ice Storm, Decay, etc.) with a selected target, the extraTargetId is included in the hit list without checking AreaSkillHitsPlayer. This means area skills can damage players even when PvP area damage is disabled in the configuration.
Fix: Add AreaSkillHitsPlayer validation to the extraTarget inclusion check.
Let me know if any of these are worth a PR — I can submit them individually or as a batch. I'm actively working on this codebase and will likely find more issues along the way, so let me know if you'd like me to keep reporting/contributing fixes as I go.
Hi! I've been self-hosting OpenMU with the open-source MuMain client and found a few bugs while testing PvP and general gameplay. Happy to submit PRs if any of these are useful.
1. Soul Barrier / Mana Shield damage overflow
File:
AttackableExtensions.csline 242When
SoulBarrierReceiveDecrementexceeds 1.0, the damage reduction calculation produces negative values that overflow to massive positive numbers (~4 billion damage). Players with Mana Shield active take MORE damage instead of less.Fix: Clamp the reduction value to 0-0.9 and ensure damage never goes below 0.
2. Area Skill extraTarget bypasses AreaSkillHitsPlayer check
File:
AreaSkillAttackAction.cs~line 108When a player casts an AoE skill (Ice Storm, Decay, etc.) with a selected target, the
extraTargetIdis included in the hit list without checkingAreaSkillHitsPlayer. This means area skills can damage players even when PvP area damage is disabled in the configuration.Fix: Add
AreaSkillHitsPlayervalidation to theextraTargetinclusion check.Let me know if any of these are worth a PR — I can submit them individually or as a batch. I'm actively working on this codebase and will likely find more issues along the way, so let me know if you'd like me to keep reporting/contributing fixes as I go.