supabase.functions.invoke returns null data when response is non-2xxx

[nounder]

Bug report

Describe the bug

When calling supabase.functions.invoke to a function that responds with non-2xx status code following error is returned with null data:

FunctionsHttpError: Edge Function returned a non-2xx status code

Supabase gives full freedom on how Edge Functions are implemented without enforcing any schema. However, supabase-js is enforcing some response schema because it discards response body when status is non-2xx.

To Reproduce

1. Deploy Edge functions that returns

return new Response("Malformed request", { headers: { status: Status.BadRequest } })

2. Call supabase.functions.invoke to it and see that data is null.

Expected behavior

data is available when Edge Functions responds with non-2xx response.

[bombillazo]

This and #55 are pretty much duplicates, I explained in the other Issue why its happening.

In this specific issue, the client checks if any errors happened during the fetch, if it has a RelayError, or if the response did not return a 2xx response. If any of these happen, the client will directly skip the data response and only return the error thrown internally inside the client, not the error causing throw:

functions-js/src/FunctionsClient.ts

Lines 115 to 117 in af4113a

	} catch (error) {
	return { data: null, error }
	}

That said, the error returned in the payload has a context property that should contain the causing error:

functions-js/src/FunctionsClient.ts

Lines 80 to 99 in af4113a

	const response = await this.fetch(`${this.url}/${functionName}`, {
	method: method || 'POST',
	// headers priority is (high to low):
	// 1. invoke-level headers
	// 2. client-level headers
	// 3. default Content-Type header
	headers: { ..._headers, ...this.headers, ...headers },
	body,
	}).catch((fetchError) => {
	throw new FunctionsFetchError(fetchError)
	})
	const isRelayError = response.headers.get('x-relay-error')
	if (isRelayError && isRelayError === 'true') {
	throw new FunctionsRelayError(response)
	}
	if (!response.ok) {
	throw new FunctionsHttpError(response)
	}

Depending on the source, you'll get the response or the fetch error.

[dts]

Perhaps relevant, when testing error states using Deno test, if you don't await the error.context.json() (or not JSON, if you have a non-json endpoint), you can a gross (and somewhat confusing) test failure:

 ERRORS 

legacy-auth ... test name => https://deno.land/std@0.210.0/testing/_test_suite.ts:323:15
error: Leaking resources:
  - A fetch response body (rid 22) was created during the test, but not consumed during the test. Consume or close the response body `ReadableStream`, e.g `await resp.text()` or `await resp.body.cancel()`.

 FAILURES 

[Mihai-github]

Still happening is there any live solution or we still waiting for official fix?

[williamlmao]

+1 on this issue. Its making it difficult to debug things in production as our sentry errors just show edge Function returned a non-2xx status code

+1

[0xpaperhead]

+1

[dominik-rehse]

+1

[branaust]

+1

[lavisht22]

+1

[pariah140]

This is baffling. I am also getting this response but I know from the function code that is definitely intending to return a 200 status.

[Suzan-Dev]

+1

[AwakenedMind]

+!