Skip to content

fix(langchain): keyword_search raises on gRPC UNIMPLEMENTED, README missing methods #43

Description

@polaz

Problem

CoordinodeGraph.keyword_search() raises an uncaught exception when the server returns StatusCode.UNIMPLEMENTED (i.e. older CoordiNode versions without the TextSearch endpoint). The docstring says it should return [] in this case, but only handles AttributeError (method not found), not gRPC errors.

Fix

  • Wrap text_search() call in try/except Exception with logger.debug(...) — same pattern used in refresh_schema()
  • Add regression test test_returns_empty_when_text_search_raises

Also

Closes part of the work from #22.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions