fix(langchain): use "id" key in keyword_search() output, matching similarity_search()

Both search methods now return dicts with "id" as the node identifier key.
Docstring updated to document the cross-method consistency guarantee.

Author: polaz

langchain-coordinode/langchain_coordinode/graph.py

@@ -273,9 +273,10 @@ def keyword_search(
         """Find nodes matching a full-text BM25 query.
 
         Wraps ``CoordinodeClient.text_search()``.  The returned list contains
-        one dict per result with the keys ``node_id`` (integer internal ID),
-        ``score`` (BM25 relevance score, higher = more relevant), and
-        ``snippet`` (HTML-highlighted excerpt, may be empty).
+        one dict per result with the keys ``id`` (integer internal node ID,
+        matches the key used by :meth:`similarity_search`), ``score`` (BM25
+        relevance score, higher = more relevant), and ``snippet``
+        (HTML-highlighted excerpt, may be empty).
 
         A full-text index must exist on *label* before calling this method.
         Create one via the Cypher DDL statement::
@@ -313,7 +314,9 @@ def keyword_search(
             fuzzy=fuzzy,
             language=language,
         )
-        return [{"node_id": r.node_id, "score": r.score, "snippet": r.snippet} for r in results]
+        # Use "id" (not "node_id") for consistency with similarity_search() return
+        # format, so callers can write generic code over both methods.
+        return [{"id": r.node_id, "score": r.score, "snippet": r.snippet} for r in results]
 
     def similarity_search(
         self,

tests/unit/test_langchain_graph.py

@@ -50,7 +50,8 @@ def text_search(
         return self._results
 
     def close(self) -> None:
-        pass
+        # No-op: keeps interface parity with real CoordinodeClient.
+        return None
 
 
 class _ClientWithoutTextSearch:
@@ -60,15 +61,16 @@ def cypher(self, query: str, params: dict | None = None) -> list[dict]:
         return []
 
     def close(self) -> None:
-        pass
+        # No-op: keeps interface parity with real CoordinodeClient.
+        return None
 
 
 # ── Tests: keyword_search ─────────────────────────────────────────────────────
 
 
 class TestKeywordSearch:
     def test_returns_list_of_dicts(self) -> None:
-        """keyword_search returns list[dict] with node_id/score/snippet keys."""
+        """keyword_search returns list[dict] with id/score/snippet keys."""
         results = [
             _FakeTextResult(node_id=1, score=0.95, snippet="<b>machine</b> learning"),
             _FakeTextResult(node_id=2, score=0.72, snippet=""),
@@ -79,8 +81,8 @@ def test_returns_list_of_dicts(self) -> None:
         out = graph.keyword_search("machine learning", k=5, label="Article")
 
         assert len(out) == 2
-        assert out[0] == {"node_id": 1, "score": 0.95, "snippet": "<b>machine</b> learning"}
-        assert out[1] == {"node_id": 2, "score": 0.72, "snippet": ""}
+        assert out[0] == {"id": 1, "score": 0.95, "snippet": "<b>machine</b> learning"}
+        assert out[1] == {"id": 2, "score": 0.72, "snippet": ""}
 
     def test_passes_params_to_client(self) -> None:
         """keyword_search forwards label, query, k, fuzzy, language to client.text_search."""