Add STORMPY_prefix to CMake#398
Open
volkm wants to merge 3 commits into
Open
Conversation
Contributor
|
Great. I just wondered whether STORMPY_CARL_DIR_HINT or STORMPY_STORM_DIR_HINT is the right way? Should this not be just STORM_DIR_HINT? |
Contributor
Author
|
I agree that it looks a bit weird. I had two main thoughts:
But I have no strong opinion and could also implement your suggestion. |
Contributor
|
I think it is a good idea, my main frustration would be if I would need to set STORMPY_STORM_DIR_HINT=... PAYNT_STORM_DIR_HINT=... |
Contributor
Author
|
I can understand it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
STORMPY_Xprefix to CMake options. Helps with distinguishing from Storm CMake options.Will maybe require an adaption in PAYNT as well.