refactor: use official urfave/cli completion scripts via embed

Author: stevengregory

cmd/autocomplete/bash_autocomplete

@@ -0,0 +1,35 @@
+#! /bin/bash
+
+: ${PROG:=$(basename ${BASH_SOURCE})}
+
+# Macs have bash3 for which the bash-completion package doesn't include
+# _init_completion. This is a minimal version of that function.
+_cli_init_completion() {
+  COMPREPLY=()
+  _get_comp_words_by_ref "$@" cur prev words cword
+}
+
+_cli_bash_autocomplete() {
+  if [[ "${COMP_WORDS[0]}" != "source" ]]; then
+    local cur opts base words
+    COMPREPLY=()
+    cur="${COMP_WORDS[COMP_CWORD]}"
+    if declare -F _init_completion >/dev/null 2>&1; then
+      _init_completion -n "=:" || return
+    else
+      _cli_init_completion -n "=:" || return
+    fi
+    words=("${words[@]:0:$cword}")
+    if [[ "$cur" == "-"* ]]; then
+      requestComp="${words[*]} ${cur} --generate-bash-completion"
+    else
+      requestComp="${words[*]} --generate-bash-completion"
+    fi
+    opts=$(eval "${requestComp}" 2>/dev/null)
+    COMPREPLY=($(compgen -W "${opts}" -- ${cur}))
+    return 0
+  fi
+}
+
+complete -o bashdefault -o default -o nospace -F _cli_bash_autocomplete $PROG
+unset PROG

cmd/autocomplete/zsh_autocomplete

@@ -0,0 +1,20 @@
+#compdef $PROG
+
+_cli_zsh_autocomplete() {
+  local -a opts
+  local cur
+  cur=${words[-1]}
+  if [[ "$cur" == "-"* ]]; then
+    opts=("${(@f)$(${words[@]:0:#words[@]-1} ${cur} --generate-bash-completion)}")
+  else
+    opts=("${(@f)$(${words[@]:0:#words[@]-1} --generate-bash-completion)}")
+  fi
+
+  if [[ "${opts[1]}" != "" ]]; then
+    _describe 'values' opts
+  else
+    _files
+  fi
+}
+
+compdef _cli_zsh_autocomplete $PROG

cmd/completion.go

@@ -1,11 +1,19 @@
 package cmd
 
 import (
+	_ "embed"
 	"fmt"
+	"strings"
 
 	"github.com/urfave/cli/v2"
 )
 
+//go:embed autocomplete/bash_autocomplete
+var bashScriptTemplate string
+
+//go:embed autocomplete/zsh_autocomplete
+var zshScriptTemplate string
+
 // CompletionCommand returns the completion command
 func CompletionCommand() *cli.Command {
 	return &cli.Command{
@@ -16,60 +24,22 @@ func CompletionCommand() *cli.Command {
 				Name:  "bash",
 				Usage: "Generate bash completion script",
 				Action: func(c *cli.Context) error {
-					fmt.Println(bashCompletionScript)
+					// Replace $PROG placeholder with actual program name
+					script := strings.ReplaceAll(bashScriptTemplate, "$PROG", "musing")
+					fmt.Print(script)
 					return nil
 				},
 			},
 			{
 				Name:  "zsh",
 				Usage: "Generate zsh completion script",
 				Action: func(c *cli.Context) error {
-					fmt.Println(zshCompletionScript)
+					// Replace $PROG placeholder with actual program name
+					script := strings.ReplaceAll(zshScriptTemplate, "$PROG", "musing")
+					fmt.Print(script)
 					return nil
 				},
 			},
 		},
 	}
 }
-
-const bashCompletionScript = `#! /bin/bash
-
-_musing_bash_autocomplete() {
-    if [[ "${COMP_WORDS[0]}" != "source" ]]; then
-        local cur opts base
-        COMPREPLY=()
-        cur="${COMP_WORDS[COMP_CWORD]}"
-        if [[ "$cur" == "-"* ]]; then
-            opts=$( ${COMP_WORDS[@]:0:$COMP_CWORD} ${cur} --generate-bash-completion )
-        else
-            opts=$( ${COMP_WORDS[@]:0:$COMP_CWORD} --generate-bash-completion )
-        fi
-        COMPREPLY=( $(compgen -W "${opts}" -- ${cur}) )
-        return 0
-    fi
-}
-
-complete -o bashdefault -o default -o nospace -F _musing_bash_autocomplete musing
-`
-
-const zshCompletionScript = `#compdef musing
-
-_musing_zsh_autocomplete() {
-    local -a opts
-    local cur
-    cur=${words[-1]}
-    if [[ "$cur" == "-"* ]]; then
-        opts=("${(@f)$(_CLI_ZSH_AUTOCOMPLETE_HACK=1 ${words[@]:0:#words[@]-1} ${cur} --generate-bash-completion)}")
-    else
-        opts=("${(@f)$(_CLI_ZSH_AUTOCOMPLETE_HACK=1 ${words[@]:0:#words[@]-1} --generate-bash-completion)}")
-    fi
-
-    if [[ "${opts[1]}" != "" ]]; then
-        _describe 'values' opts
-    else
-        _files
-    fi
-}
-
-compdef _musing_zsh_autocomplete musing
-`