add strict rules for phpstan

Author: vstelmakh

composer.json

@@ -19,6 +19,7 @@
     "require-dev": {
         "friendsofphp/php-cs-fixer": "^3.87",
         "phpstan/phpstan": "^2.1",
+        "phpstan/phpstan-strict-rules": "^2.0",
         "phpunit/phpunit": "^13.0",
         "symfony/process": "^7.3 || ^8"
     },

phpstan.neon

@@ -1,3 +1,6 @@
+includes:
+    - vendor/phpstan/phpstan-strict-rules/rules.neon
+
 parameters:
   level: 8
   tmpDir: var/phpstan

src/Router/Compiler/RouteCompilerVisitor.php

@@ -30,7 +30,7 @@ public function __construct(
     public function visitRoute(Route $route): void
     {
         $canonicalPath = $this->getCanonicalPath($route->path);
-        $isFile = preg_match('/\.\w+$/', $canonicalPath);
+        $isFile = (bool) preg_match('/\.\w+$/', $canonicalPath);
         $distPath = rtrim($canonicalPath) . ($isFile ? '' : '/index.html');
         $type = new ControllerResource($route->controller, $route->parameters);
         $name = $route->name;

src/Server/Server.php

@@ -139,11 +139,11 @@ private function validatePath(string $path): void
 
     private function validateHost(string $host): void
     {
-        if (filter_var($host, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME)) {
+        if (filter_var($host, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME) !== false) {
             return;
         }
 
-        if (filter_var($host, FILTER_VALIDATE_IP)) {
+        if (filter_var($host, FILTER_VALIDATE_IP) !== false) {
             return;
         }
 

tests/Functional/StasisProcessFactory.php

@@ -21,8 +21,12 @@ public static function create(array $arguments = [], ?string $workdir = null): P
 
     private static function getStasisPath(): string
     {
-        /** @var string $kernelPath */
         $kernelPath = new \ReflectionClass(Kernel::class)->getFileName();
+
+        if ($kernelPath === false) {
+            throw new \RuntimeException('Failed to get kernel path.');
+        }
+
         return dirname($kernelPath, 2) . '/bin/stasis';
     }
 }

tests/Unit/Console/ApplicationFactoryTest.php

@@ -12,7 +12,7 @@ class ApplicationFactoryTest extends TestCase
 {
     public function testCreateBuildsConfiguredApplication(): void
     {
-        $kernel = $this->createStub(Kernel::class);
+        $kernel = self::createStub(Kernel::class);
         $application = ApplicationFactory::create($kernel);
 
         self::assertSame('Stasis', $application->getName(), 'Unexpected application name.');

tests/Unit/Console/Command/GenerateCommandTest.php

@@ -31,11 +31,11 @@ class GenerateCommandTest extends TestCase
     #[\Override]
     public function setUp(): void
     {
-        $this->kernel = $this->createStub(Kernel::class);
+        $this->kernel = self::createStub(Kernel::class);
         $this->generator = $this->createMock(SiteGenerator::class);
         $this->compiler = $this->createMock(RouteCompiler::class);
         $this->routes = [];
-        $this->stopwatch = $this->createStub(Stopwatch::class);
+        $this->stopwatch = self::createStub(Stopwatch::class);
 
         $this->command = new GenerateCommand(
             $this->generator,

tests/Unit/Console/Command/ServerCommandTest.php

@@ -27,9 +27,9 @@ class ServerCommandTest extends TestCase
     #[\Override]
     public function setUp(): void
     {
-        $this->kernel = $this->createStub(Kernel::class);
-        $this->distribution = $this->createStub(LocalDistributionInterface::class);
-        $this->serverFactory = $this->createStub(ServerFactory::class);
+        $this->kernel = self::createStub(Kernel::class);
+        $this->distribution = self::createStub(LocalDistributionInterface::class);
+        $this->serverFactory = self::createStub(ServerFactory::class);
 
         $this->command = new ServerCommand(
             $this->distribution,
@@ -172,8 +172,8 @@ public function testExecuteVerbose(): void
     public function testUnsupportedDistribution(): void
     {
         // plain distribution (not local) should fail
-        $distribution = $this->createStub(DistributionInterface::class);
-        $factory = $this->createStub(ServerFactory::class);
+        $distribution = self::createStub(DistributionInterface::class);
+        $factory = self::createStub(ServerFactory::class);
         $command = new ServerCommand($distribution, $factory);
 
         $tester = new CommandTester($command);

tests/Unit/Console/CommandLoaderTest.php

@@ -22,7 +22,7 @@ class CommandLoaderTest extends TestCase
     #[\Override]
     public function setUp(): void
     {
-        $this->kernel = $this->createStub(Kernel::class);
+        $this->kernel = self::createStub(Kernel::class);
         $this->loader = new CommandLoader($this->kernel, [
             StubACommand::class,
             StubBCommand::class,

tests/Unit/EventDispatcher/EventTestCase.php

@@ -39,7 +39,7 @@ public function testAcceptMatchingListener(): void
     public function testAcceptNonMatchingListener(): void
     {
         $event = $this->getEvent();
-        $listener = $this->createStub(ListenerInterface::class);
+        $listener = self::createStub(ListenerInterface::class);
         $isAccepted = $event->accept($listener);
         self::assertFalse($isAccepted, 'Event should not be accepted by a non-matching listener.');
     }