chore: remove unncessary duplicate label for managed by

Signed-off-by: Jan Larwig <jan.larwig@digits.schwarz>

Author: tuunit

cloud/sdk_client.go

@@ -1055,7 +1055,6 @@ func clusterServerSelectorFromTags(tags map[string]string) map[string]string {
 		"cluster.x-k8s.io/cluster-name",
 		"cluster.x-k8s.io/cluster-namespace",
 		"cluster.x-k8s.io/managed-by",
-		"cluster-api-provider-stackit/managed",
 	} {
 		if value := tags[key]; value != "" {
 			selector[key] = value

util/tags.go

@@ -20,17 +20,15 @@ const (
 	LabelMachineName      = "cluster.x-k8s.io/machine-name"
 	LabelMachineUID       = "cluster.x-k8s.io/machine-uid"
 	LabelManagedBy        = "cluster.x-k8s.io/managed-by"
-	LabelProviderManaged  = "cluster-api-provider-stackit/managed"
 	LabelResourceRole     = "cluster-api-provider-stackit/resource-role"
 	LabelE2E              = "cluster-api-provider-stackit/e2e"
 	LabelTestID           = "cluster-api-provider-stackit/test-id"
 
 	// ManagedByValue identifies resources managed by this provider.
-	ManagedByValue       = "cluster-api-provider-stackit"
-	ProviderManagedValue = "true"
-	ResourceRoleBastion  = "bastion"
-	ResourceRoleNodeSSH  = "node-ssh"
-	E2EValue             = "true"
+	ManagedByValue      = "cluster-api-provider-stackit"
+	ResourceRoleBastion = "bastion"
+	ResourceRoleNodeSSH = "node-ssh"
+	E2EValue            = "true"
 )
 
 // ClusterTags returns the canonical tags applied to cluster-wide cloud
@@ -41,7 +39,6 @@ func ClusterTags(clusterName, clusterNamespace string, additionalLabels map[stri
 		LabelClusterName:      clusterName,
 		LabelClusterNamespace: clusterNamespace,
 		LabelManagedBy:        ManagedByValue,
-		LabelProviderManaged:  ProviderManagedValue,
 	}
 	for k, v := range additionalLabels {
 		if _, isReserved := out[k]; isReserved {
@@ -65,7 +62,6 @@ func MachineTags(
 		LabelMachineName:      machineName,
 		LabelMachineUID:       machineUID,
 		LabelManagedBy:        ManagedByValue,
-		LabelProviderManaged:  ProviderManagedValue,
 	}
 	for k, v := range additionalLabels {
 		if _, isReserved := out[k]; isReserved {

util/tags_test.go

@@ -18,35 +18,31 @@ func TestClusterTags(t *testing.T) {
 		LabelClusterName:      "override",
 		LabelClusterNamespace: "override",
 		LabelManagedBy:        "override",
-		LabelProviderManaged:  "override",
 		"another.example":     "value",
 	})
 
 	assertTag(t, got, LabelClusterName, "cluster-a")
 	assertTag(t, got, LabelClusterNamespace, "default")
 	assertTag(t, got, LabelManagedBy, ManagedByValue)
-	assertTag(t, got, LabelProviderManaged, ProviderManagedValue)
 	assertTag(t, got, "environment", "dev")
 	assertTag(t, got, "another.example", "value")
 }
 
 func TestMachineTags(t *testing.T) {
 	got := MachineTags("cluster-a", "default", "machine-a", "uid-a", map[string]string{
-		"environment":        "dev",
-		LabelMachineName:     "override",
-		LabelMachineUID:      "override",
-		LabelManagedBy:       "override",
-		LabelProviderManaged: "override",
-		LabelClusterName:     "override",
-		"another.example":    "value",
+		"environment":     "dev",
+		LabelMachineName:  "override",
+		LabelMachineUID:   "override",
+		LabelManagedBy:    "override",
+		LabelClusterName:  "override",
+		"another.example": "value",
 	})
 
 	assertTag(t, got, LabelClusterName, "cluster-a")
 	assertTag(t, got, LabelClusterNamespace, "default")
 	assertTag(t, got, LabelMachineName, "machine-a")
 	assertTag(t, got, LabelMachineUID, "uid-a")
 	assertTag(t, got, LabelManagedBy, ManagedByValue)
-	assertTag(t, got, LabelProviderManaged, ProviderManagedValue)
 	assertTag(t, got, "environment", "dev")
 	assertTag(t, got, "another.example", "value")
 }