unable to generate new golden result

[piq9117]

I did this change on the json example

diff --git a/examples/json/src/Json.hs b/examples/json/src/Json.hs
index db30868..0f55b64 100644
--- a/examples/json/src/Json.hs
+++ b/examples/json/src/Json.hs
@@ -18,7 +18,7 @@ data Country = Country
 instance ToJSON Country


-ecuador = Country "Ecuador" "America" 1
+ecuador = Country "Ecuador" "America Change" 1
 germany = Country "Germany" "Europe" 2
 japan = Country "Japan" "Asia" 4

Ran the test and as expected I get this result

JsonGolden
  encodeCountries
    encodes a group of Countries into a JSON bytestring  [✘]
      Files golden and actual not match

Failures:

  test/JsonGoldenSpec.hs:25:4:
  1) JsonGolden.encodeCountries encodes a group of Countries into a JSON bytestring
       expected: "[{\"cname\":\"Ecuador\",\"continent\":\"America\",\"ctag\":1},{\"cname\":\"Germany\",\"continent\":\"Europe\",\"ctag\":2},{\"cname\":\"Japan\",\"continent\":\"Asia\",\"ctag\":4}]"
        but got: "[{\"cname\":\"Ecuador\",\"continent\":\"America Change\",\"ctag\":1},{\"cname\":\"Germany\",\"continent\":\"Europe\",\"ctag\":2},{\"cname\":\"Japan\",\"continent\":\"Asia\",\"ctag\":4}]"

  To rerun use: --match "/JsonGolden/encodeCountries/encodes a group of Countries into a JSON bytestring /"

Randomized with seed 2045427810

Finished in 0.0024 seconds
1 example, 1 failure

So I ran stack exec hgold -- --update .otherGolden/ and I get this from stdout

Replacing golden with actual:
Finished!

However, when I ran the test again. I get the same failing result

JsonGolden
  encodeCountries
    encodes a group of Countries into a JSON bytestring  [✘]
      Files golden and actual not match

Failures:

  test/JsonGoldenSpec.hs:25:4:
  1) JsonGolden.encodeCountries encodes a group of Countries into a JSON bytestring
       expected: "[{\"cname\":\"Ecuador\",\"continent\":\"America\",\"ctag\":1},{\"cname\":\"Germany\",\"continent\":\"Europe\",\"ctag\":2},{\"cname\":\"Japan\",\"continent\":\"Asia\",\"ctag\":4}]"
        but got: "[{\"cname\":\"Ecuador\",\"continent\":\"America Change\",\"ctag\":1},{\"cname\":\"Germany\",\"continent\":\"Europe\",\"ctag\":2},{\"cname\":\"Japan\",\"continent\":\"Asia\",\"ctag\":4}]"

  To rerun use: --match "/JsonGolden/encodeCountries/encodes a group of Countries into a JSON bytestring /"

Randomized with seed 1668369998

Finished in 0.0025 seconds
1 example, 1 failure

[piq9117]

going back to this. I can see how this will be tedious to make the cli work. The cli is just blindly making assumptions on the filepaths since it doesn't have access to the Golden configuration I think the path of least resistance to make the cli work is to remove goldenFile and actualFile from Golden. Instead of making those filepaths configurable, hspec-golden will just decide it for the user. Here's may take on it https://github.com/piq9117/hspec-golden/pull/1/files

[CristhianMotoche]

Hello @piq9117 Thanks for reporting this issue. Your approach looks good to me! Let me know if we could include it in this repo to prepare a new release.

[piq9117]

Thanks for the response. I'll submit a PR