From af5d009fbcbd8ab2c925a7f72587a34d86687214 Mon Sep 17 00:00:00 2001 From: Joshua Temple Date: Sun, 5 Jul 2026 11:16:58 -0400 Subject: [PATCH] docs(contributing): require fleet suites to move with generator eligibility changes Signed-off-by: Joshua Temple --- CONTRIBUTING.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a7b72faa..c016d10c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -36,8 +36,9 @@ golangci-lint run ./... 2. Branch from `main`. 3. Keep changes focused. One logical change per pull request. 4. Add or update tests. New manifest fields and generator features need an `e2e/` scenario, not just a unit test on generated output. -5. Run `go test ./...` and `golangci-lint run ./...` before pushing. -6. Use [Conventional Commits](https://www.conventionalcommits.org/) for commit messages (`feat:`, `fix:`, `docs:`, `chore:`, ...). cascade derives changelogs and version bumps from them. +5. If a change alters which operations are valid on which environments (for example, which environments are eligible for rollback or promotion), update the fleet example-repo suites that exercise those operations in the same change. A generator or CLI eligibility rule and the fleet suite that asserts against it are one coupled unit; letting them drift hides the mismatch until a later fleet run exercises the now invalid path. +6. Run `go test ./...` and `golangci-lint run ./...` before pushing. +7. Use [Conventional Commits](https://www.conventionalcommits.org/) for commit messages (`feat:`, `fix:`, `docs:`, `chore:`, ...). cascade derives changelogs and version bumps from them. ## API design