Skip to content

linux: lazy call XInitThreads#75

Open
Adphi wants to merge 1 commit into
sqweek:masterfrom
linka-cloud:master
Open

linux: lazy call XInitThreads#75
Adphi wants to merge 1 commit into
sqweek:masterfrom
linka-cloud:master

Conversation

@Adphi

@Adphi Adphi commented Apr 17, 2023

Copy link
Copy Markdown

This prevents a program that can run as a command line tool from displaying "Unable to init server: Could not connect: Connection refused".

Signed-off-by: Adphi <philippe.adrien.nousse@gmail.com>
@Adphi Adphi changed the title linux: lazy call to XInitThreads linux: lazy call XInitThreads Apr 18, 2023
@sqweek

sqweek commented May 11, 2023

Copy link
Copy Markdown
Owner

I looked at this PR when you first opened it and was going to do something with it but I haven't had much bandwidth lately sorry.

Thanks for your work! The change makes sense, but I'd like to take it a bit further before landing it:

  1. rename checkStatus() to lazyInit() or similar
  2. drop the initSuccess global (ie. panic() within the lazy init block that calls gtk_init_check)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants