Repository navigation
Commit b920257
committed
compiler: set newParser for the engines main added, and cover hidden columns
Rebasing onto main brought two things this change has to answer for.
SQL Server and DuckDB were added to initCore assigning c.parser
directly, while this branch had taken to deriving c.parser from
c.newParser at the end of the same switch. Neither side conflicted, so
the rebase produced a switch that leaves newParser nil for those two
engines and then calls it — every SQL Server and DuckDB query set
panicked. They set newParser like the rest now.
An fts5 table offers columns it does not declare, and a star must not
expand to them. The analyzer already skips a hidden column, and the
merge carried that into the star's column list along with the result
set, which is what it should do. Nothing covered it: the fts5 case
selects named columns, and it only runs under the opt-in core context.
star_expansion_core selects a star from an fts5 table on sqlite, where
it runs in the default suite, and expands to the declared column alone
the way the legacy path does.
The goldens are regenerated for codegen emitting any over interface{}.1 parent ff21d6e commit b920257
8 files changed
Lines changed: 82 additions & 11 deletions
File tree
- internal
- compiler
- endtoend/testdata/star_expansion_core
- mysql/go
- postgresql/go
- sqlite
- go
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
153 | | - | |
| 153 | + | |
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
157 | | - | |
| 157 | + | |
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
0 commit comments