Skip to content

Commit 2c47512

Browse files
committed
golang: emit one argument for a named parameter used more than once
Agent: claude
1 parent 1911a76 commit 2c47512

7 files changed

Lines changed: 97 additions & 1 deletion

File tree

‎internal/codegen/golang/query.go‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,8 @@ func (v QueryValue) Pairs() []Argument {
7272
}
7373
if !v.EmitStruct() && v.IsStruct() {
7474
var out []Argument
75-
for _, f := range v.Struct.Fields {
75+
// A named parameter used more than once is one field, so one argument.
76+
for _, f := range v.UniqueFields() {
7677
out = append(out, Argument{
7778
Name: escape(toLowerCase(f.Name)),
7879
Type: f.Type,

‎internal/endtoend/testdata/query_parameter_limit_repeated_narg/mysql/go/db.go‎

Lines changed: 31 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/endtoend/testdata/query_parameter_limit_repeated_narg/mysql/go/models.go‎

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/endtoend/testdata/query_parameter_limit_repeated_narg/mysql/go/query.sql.go‎

Lines changed: 38 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
-- name: ListUsers :many
2+
SELECT name FROM users WHERE (name = sqlc.narg(name) OR sqlc.narg(name) IS NULL) AND age > sqlc.arg(min_age);
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
CREATE TABLE users (name TEXT NOT NULL, age INT NOT NULL);
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
{
2+
"version": "1",
3+
"packages": [
4+
{
5+
"path": "go",
6+
"engine": "mysql",
7+
"name": "querytest",
8+
"schema": "schema.sql",
9+
"queries": "query.sql",
10+
"query_parameter_limit": 5
11+
}
12+
]
13+
}

0 commit comments

Comments
 (0)