Skip to content

Commit 1c22d51

Browse files
committed
goldeneye: read SQLite function signatures from the amalgamation
SQLite records nothing about what its functions return or take, but its source does, in its way: every function is registered with the C functions that implement it, and those set their result through sqlite3_result_* and read their arguments through sqlite3_value_*. So instead of a hand-written table of signatures, the generator now reads the amalgamation the shells are built from. It indexes every function definition, reads the FuncDef macro tables, the sqlite3_create_function calls and the struct tables extensions walk, follows each implementation and the helpers it calls for result calls, and reads each argument's position for value calls. One kind of result is that type; a function that returns one of its arguments is "any"; integer and real together widen to real, text and blob together to text; a JSON function's registration says whether it returns text or JSONB; a function the VDBE implements in bytecode passes an argument through. A function the shell reports that the source does not register, or whose implementation sets no result, fails the run. Whether an aggregate returns NULL over no rows is found by running each over none, in one shell process per build. Which scalar functions return NULL for arguments that are not is what neither the shell nor the source can say — a SQLite function returns NULL as often by setting no result as by saying so — so that remains a short list, with the functions the dialect omits and the one inline function that does not pass an argument through. The regenerated dialect differs where the source knows better: ceil, floor and trunc return real for real input; unixepoch can; format, printf, instr and length are not nullable for arguments that are not, and neither are coalesce, iif and their kin; round's second argument and the math functions' arguments are typed; hex takes a blob. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RYkxvtwH6GgysuWYP87vyj
1 parent ea6e341 commit 1c22d51

11 files changed

Lines changed: 812 additions & 369 deletions

File tree

‎internal/endtoend/testdata/builtins/sqlite/go/mathfunc.sql.go‎

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/endtoend/testdata/builtins/sqlite/go/scalarfunc.sql.go‎

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎internal/engine/sqlite/dialect/extensions/enable_fts3/functions.jsonl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
{"name":"matchinfo","args":[{"type":"any"},{"type":"text"}],"returns":"blob"}
33
{"name":"offsets","args":[{"type":"any"}],"returns":"text"}
44
{"name":"optimize","args":[{"type":"any"}],"returns":"text"}
5-
{"name":"snippet","args":[{"type":"text","has_default":true},{"type":"integer","has_default":true},{"type":"text","has_default":true},{"type":"text","has_default":true},{"type":"text","has_default":true},{"type":"integer","has_default":true},{"type":"any","mode":"v"}],"returns":"text"}
5+
{"name":"snippet","args":[{"type":"any","has_default":true},{"type":"any","has_default":true},{"type":"text","has_default":true},{"type":"text","has_default":true},{"type":"integer","has_default":true},{"type":"integer","has_default":true},{"type":"any","mode":"v"}],"returns":"text"}
Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
{"name":"bm25","args":[{"type":"text","has_default":true},{"type":"real","mode":"v"}],"returns":"real"}
2-
{"name":"fts5_get_locale","args":[{"type":"any","has_default":true},{"type":"any","has_default":true},{"type":"any","mode":"v"}],"returns":"text","nullable":true}
3-
{"name":"fts5_insttoken","args":[{"type":"text"}],"returns":"text"}
1+
{"name":"bm25","args":[{"type":"any","has_default":true},{"type":"real","mode":"v"}],"returns":"real"}
2+
{"name":"fts5_get_locale","args":[{"type":"any","has_default":true},{"type":"integer","has_default":true},{"type":"any","mode":"v"}],"returns":"text","nullable":true}
3+
{"name":"fts5_insttoken","args":[{"type":"any"}],"returns":"any"}
44
{"name":"fts5_locale","args":[{"type":"text"},{"type":"text"}],"returns":"text"}
55
{"name":"fts5_source_id","returns":"text"}
6-
{"name":"highlight","args":[{"type":"text","has_default":true},{"type":"integer","has_default":true},{"type":"text","has_default":true},{"type":"text","has_default":true},{"type":"any","mode":"v"}],"returns":"text"}
7-
{"name":"snippet","args":[{"type":"text","has_default":true},{"type":"integer","has_default":true},{"type":"text","has_default":true},{"type":"text","has_default":true},{"type":"text","has_default":true},{"type":"integer","has_default":true},{"type":"any","mode":"v"}],"returns":"text"}
6+
{"name":"highlight","args":[{"type":"any","has_default":true},{"type":"integer","has_default":true},{"type":"text","has_default":true},{"type":"text","has_default":true},{"type":"any","mode":"v"}],"returns":"text"}
7+
{"name":"snippet","args":[{"type":"any","has_default":true},{"type":"any","has_default":true},{"type":"text","has_default":true},{"type":"text","has_default":true},{"type":"integer","has_default":true},{"type":"integer","has_default":true},{"type":"any","mode":"v"}],"returns":"text"}

‎internal/engine/sqlite/dialect/extensions/enable_geopoly/functions.jsonl‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
{"name":"geopoly_json","args":[{"type":"any"}],"returns":"text","nullable":true}
88
{"name":"geopoly_overlap","args":[{"type":"any"},{"type":"any"}],"returns":"integer","nullable":true}
99
{"name":"geopoly_regular","args":[{"type":"real"},{"type":"real"},{"type":"real"},{"type":"integer"}],"returns":"blob"}
10-
{"name":"geopoly_svg","args":[{"type":"any","has_default":true},{"type":"text","has_default":true},{"type":"any","mode":"v"}],"returns":"text","nullable":true}
10+
{"name":"geopoly_svg","args":[{"type":"text","mode":"v"}],"returns":"text","nullable":true}
1111
{"name":"geopoly_within","args":[{"type":"any"},{"type":"any"}],"returns":"integer","nullable":true}
1212
{"name":"geopoly_xform","args":[{"type":"any"},{"type":"real"},{"type":"real"},{"type":"real"},{"type":"real"},{"type":"real"},{"type":"real"}],"returns":"blob","nullable":true}
1313
{"name":"rtreecheck","args":[{"type":"text","has_default":true},{"type":"text","has_default":true},{"type":"any","mode":"v"}],"returns":"text"}
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
{"name":"median","kind":"a","args":[{"type":"any"}],"returns":"real","nullable":true}
2-
{"name":"percentile","kind":"a","args":[{"type":"any"},{"type":"real"}],"returns":"real","nullable":true}
3-
{"name":"percentile_cont","kind":"a","args":[{"type":"any"},{"type":"real"}],"returns":"real","nullable":true}
4-
{"name":"percentile_disc","kind":"a","args":[{"type":"any"},{"type":"real"}],"returns":"any","nullable":true}
1+
{"name":"median","kind":"a","args":[{"type":"real"}],"returns":"real","nullable":true}
2+
{"name":"percentile","kind":"a","args":[{"type":"real"},{"type":"real"}],"returns":"real","nullable":true}
3+
{"name":"percentile_cont","kind":"a","args":[{"type":"real"},{"type":"real"}],"returns":"real","nullable":true}
4+
{"name":"percentile_disc","kind":"a","args":[{"type":"real"},{"type":"real"}],"returns":"real","nullable":true}

0 commit comments

Comments
 (0)