Repository navigation
Commit 0824475
fix(postgresql): name a domain's base as the parser does
The base was read the way the analysis core reads a type, lowercased
and without pg_catalog, so a domain over a quoted enum named no enum
and one over numeric missed a pg_catalog.numeric override. Keep the
parser's name, as a column of the base type has it.
Addresses review comment r4556992547 on #2.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>1 parent b429383 commit 0824475
6 files changed
Lines changed: 81 additions & 11 deletions
File tree
- internal
- endtoend/testdata
- codegen_json_domains_postgresql/gen
- domain_types/postgresql
- go
- sql/catalog
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
154 | | - | |
| 154 | + | |
155 | 155 | | |
156 | 156 | | |
157 | 157 | | |
| |||
166 | 166 | | |
167 | 167 | | |
168 | 168 | | |
169 | | - | |
| 169 | + | |
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
| |||
68811 | 68811 | | |
68812 | 68812 | | |
68813 | 68813 | | |
68814 | | - | |
| 68814 | + | |
68815 | 68815 | | |
68816 | 68816 | | |
68817 | 68817 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
4 | 8 | | |
5 | 9 | | |
6 | 10 | | |
| |||
19 | 23 | | |
20 | 24 | | |
21 | 25 | | |
22 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
23 | 29 | | |
24 | 30 | | |
25 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
| 16 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
| 6 | + | |
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| |||
132 | 133 | | |
133 | 134 | | |
134 | 135 | | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
135 | 142 | | |
136 | 143 | | |
137 | 144 | | |
| |||
0 commit comments