Hold charge should not enable inverter charge mode (SoC reserve) #3553
Description
Describe the bug
When the predbat mode changes to "Hold charging" it will almost always enable charging which for many inverters means that the battery won't be used at all even if the "Hold charging" target is lower than the current battery SoC.
Expected behaviour
I'd expect that if an inverter has has_reserve_soc configured that this value would be set and that charge_start_service would not be invoked, thus allowing the battery to be used up to the SoC defined by "Hold charging".
Predbat version
v8.34.1
Environment details
- Inverter and battery setup
Goodwe 5048D ES with 2x Pylontech US3000C
- Standard HAOS installer or Docker
Docker
- Anything else?
I've added more comments about this on another issue, but I'm starting a new issue since that's unrelated to the main purpose of that issue.
As mentioned here, I believe the code used to behave like what I'm proposing but it has since changed so I'm probably missing some context about why it cannot behave the way I think it would make more sense to my use case.