BUG/Feature request - wait until all tasks are complete

[truekonrads]

Hello,

I have an eventually finite amount of tasks which need to be processed. My code goes like this:

pool = ActionPool::Pool.new
 tasks.each do |t|
 pool.queue Proc.new {
  ...
}
end 
while pool.working >0        
         sleep 1
       end
       pool.shutdown

I see this as a bit of hack, surely something like that should be part of the pool code. For example:

class Pool
  def wait_finish(pollint=1)
   while self.working >0
   sleep pollint
  end
end

[chrisroberts]

the pool.shutdown should wait until the queue has emptied and then explicitly joins all running threads, which should be the behavior you are looking for. Are you seeing different behavior?

[truekonrads]

Yes, in some cases the pool finished without all tasks completed. This did not happen consistently, so I suspect a race condition of sorts.