diff --git a/.github/dco.yml b/.github/dco.yml new file mode 100644 index 0000000..10fd285 --- /dev/null +++ b/.github/dco.yml @@ -0,0 +1,12 @@ +allowRemediationCommits: + # Allow individual remediation commits + # https://github.com/dcoapp/app#individual-remediation-commit-support + individual: true + # Allow third-party remediation commits + # https://github.com/dcoapp/app#third-party-remediation-support + thirdParty: false + +require: + # Members are required to sign-off commits + # https://github.com/dcoapp/app#skipping-sign-off-for-organization-members + members: true diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 30fa056..8aebc05 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,3 +1,5 @@ + + ## Summary diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index a55292d..fef99d9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -31,6 +31,8 @@ the extras from the previous one (e.g. syncing `--extra dev` after ## Before you open a PR +Sign off your commits as described under [Developer Certificate of Origin](#developer-certificate-of-origin-dco). + Three checks are the minimum gate (CI runs all three): ```bash @@ -122,3 +124,34 @@ For security-related issues, do **not** open a public issue — see By submitting a PR, you agree that your contribution will be licensed under the [Apache License 2.0](LICENSE), the same license that covers the rest of the project. + +## Developer Certificate of Origin (DCO) + +Raincloud uses the [Developer Certificate of Origin 1.1](https://developercertificate.org/) +for contributions. Signing off a commit certifies that you have the right to +submit the contribution under the project's license and agree to the DCO's terms. +No separate Contributor License Agreement (CLA) is required. + +Sign off every commit, including contributions from maintainers and organization +members. With your name and email configured in Git, use: + +```bash +git commit -s -m "Describe the change" +``` + +This adds a trailer matching the commit author's name and email: + +```text +Signed-off-by: Your Real Name +``` + +Use your real name and email address, as in +[Vortex's contribution policy](https://github.com/vortex-data/vortex/blob/develop/CONTRIBUTING.md#developer-certificate-of-origin-dco). +A DCO sign-off is distinct from a cryptographic commit signature (`git commit -S`). + +If you missed the sign-off on your latest commit, add it with +`git commit --amend --no-edit -s`. For earlier commits, you can add an +[individual remediation commit](https://github.com/dcoapp/app#individual-remediation-commit-support) +instead of rewriting history. Only the original author can remediate their +commits; third-party remediation is disabled. The DCO app configuration is in +[`.github/dco.yml`](.github/dco.yml). diff --git a/clients/c/tests/CMakeLists.txt b/clients/c/tests/CMakeLists.txt index b1f3336..8f0d38a 100644 --- a/clients/c/tests/CMakeLists.txt +++ b/clients/c/tests/CMakeLists.txt @@ -16,6 +16,6 @@ if(ARROW_INCLUDE AND ARROW_LIBRARY) IMPORTED_LOCATION "${ARROW_LIBRARY}" INTERFACE_INCLUDE_DIRECTORIES "${ARROW_INCLUDE}") add_executable(read-cpp read.cpp) - target_compile_features(read-cpp PRIVATE cxx_std_17) + target_compile_features(read-cpp PRIVATE cxx_std_20) target_link_libraries(read-cpp PRIVATE raincloud::reader consumer_arrow) endif() diff --git a/scripts/test_native_readers.py b/scripts/test_native_readers.py index 800fb6f..d04ddb3 100644 --- a/scripts/test_native_readers.py +++ b/scripts/test_native_readers.py @@ -131,7 +131,7 @@ def run(args, **kwargs): arrow_dir = Path(pa.get_library_dirs()[0]) arrow_lib = sorted(arrow_dir.glob("libarrow.so*"), key=lambda p: len(p.name))[0] run(["cc", "-std=c11", "-Wall", "-Wextra", "-Werror", "clients/c/tests/read.c", f"-I{include}", f"-L{lib}", "-lraincloud_reader", f"-Wl,-rpath,{lib}", "-o", temp / "read-c"]) - run(["c++", "-std=c++17", "-Wall", "-Wextra", "-Werror", "clients/c/tests/read.cpp", f"-I{include}", "-isystem", pa.get_include(), f"-L{lib}", "-lraincloud_reader", f"-Wl,-rpath,{lib}", arrow_lib, f"-Wl,-rpath,{arrow_dir}", "-o", temp / "read-cpp"]) + run(["c++", "-std=c++20", "-Wall", "-Wextra", "-Werror", "clients/c/tests/read.cpp", f"-I{include}", "-isystem", pa.get_include(), f"-L{lib}", "-lraincloud_reader", f"-Wl,-rpath,{lib}", arrow_lib, f"-Wl,-rpath,{arrow_dir}", "-o", temp / "read-cpp"]) for exe in ("read-c", "read-cpp"): run([temp / exe, temp / "options.json", missing], env={**env, "PATH": "/nonexistent"})