Skip to content

Commit 9219886

Browse files
committed
FIX version command test
1 parent 1a5942b commit 9219886

1 file changed

Lines changed: 11 additions & 9 deletions

File tree

tests/cli/commands/test_version.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,11 @@ def test_version_command_success(mock_file_open, mock_exists, mock_get_translati
2929
"""Test version command when setup.py exists and contains version."""
3030
mock_get_translation.return_value = DUMMY_MESSAGES
3131
mock_exists.return_value = True
32-
mock_file_open.read_data = "version=\"1.2.3\",\n" # Simulate setup.py content
33-
mock_file_open.return_value.read.return_value = mock_file_open.read_data
34-
mock_file_open.return_value.__iter__.return_value = mock_file_open.read_data.splitlines()
32+
33+
# Setup mock file content with proper line structure
34+
setup_content = 'version="1.2.3",\nname="spicecode"'
35+
mock_file_open.return_value.read.return_value = setup_content
36+
mock_file_open.return_value.__iter__.return_value = iter(setup_content.splitlines())
3537

3638
version_command(LANG_FILE="dummy_lang.txt", CURRENT_DIR=TEST_CURRENT_DIR)
3739

@@ -48,9 +50,11 @@ def test_version_command_version_not_in_setup(mock_file_open, mock_exists, mock_
4850
"""Test version command when setup.py exists but lacks version info."""
4951
mock_get_translation.return_value = DUMMY_MESSAGES
5052
mock_exists.return_value = True
51-
mock_file_open.read_data = "name=\"spicecode\"\n" # Simulate setup.py without version
52-
mock_file_open.return_value.read.return_value = mock_file_open.read_data
53-
mock_file_open.return_value.__iter__.return_value = mock_file_open.read_data.splitlines()
53+
54+
# Setup mock file content without version
55+
setup_content = 'name="spicecode"\nauthor="test"'
56+
mock_file_open.return_value.read.return_value = setup_content
57+
mock_file_open.return_value.__iter__.return_value = iter(setup_content.splitlines())
5458

5559
version_command(LANG_FILE="dummy_lang.txt", CURRENT_DIR=TEST_CURRENT_DIR)
5660

@@ -88,6 +92,4 @@ def test_version_command_read_error(mock_file_open, mock_exists, mock_get_transl
8892

8993
mock_exists.assert_called_once_with(EXPECTED_SETUP_PATH)
9094
mock_file_open.assert_called_once_with(EXPECTED_SETUP_PATH, "r")
91-
assert "Error: Permission denied" in captured.out
92-
93-
95+
assert "Error: Permission denied" in captured.out

0 commit comments

Comments
 (0)