From 6f4786058dd8499232e2641d5271ff7454973bf6 Mon Sep 17 00:00:00 2001 From: Ash Godfrey Date: Mon, 16 Nov 2026 12:52:10 +0000 Subject: [PATCH] fix(typescript): compile MCP server when the document defines no servers The generated src/lib/config.ts only declares SDKOptions.serverIdx (or SDKOptions.server for named servers) when the document has a server with an absolute URL. The MCP server templates emitted the server-index flag and the serverIdx pass-through whenever any servers object existed, including the implicit default or relative-only servers, which left the generated MCP server referencing SDKOptions["serverIdx"] and failing to compile. Gate those three places on the same predicate config.ts uses. --- .changesets/1794833246-a4ee045c.yaml | 10 ++++++++++ .../typescriptv2/mcp-server/cli/start/command.ts.stmpl | 2 +- .../typescriptv2/mcp-server/cli/start/impl.ts.stmpl | 2 +- .../typescriptv2/mcp-server/create-mcp-server.ts.stmpl | 3 ++- .../templates/typescriptv2/mcp-server/server.ts.stmpl | 4 ++-- 5 files changed, 16 insertions(+), 5 deletions(-) create mode 100644 .changesets/1794833246-a4ee045c.yaml diff --git a/.changesets/1794833246-a4ee045c.yaml b/.changesets/1794833246-a4ee045c.yaml new file mode 100644 index 000000000..3c4d277f3 --- /dev/null +++ b/.changesets/1794833246-a4ee045c.yaml @@ -0,0 +1,10 @@ +id: 1794833246-a4ee045c +features: + - mcpServer +targets: + - typescriptv2 +type: fix +bump: patch +description: compile the MCP server when the OpenAPI document defines no servers +author: AshGodfrey +date: "2026-11-16" diff --git a/templates/templates/typescriptv2/mcp-server/cli/start/command.ts.stmpl b/templates/templates/typescriptv2/mcp-server/cli/start/command.ts.stmpl index 5a1f40ea2..bf9c345a1 100644 --- a/templates/templates/typescriptv2/mcp-server/cli/start/command.ts.stmpl +++ b/templates/templates/typescriptv2/mcp-server/cli/start/command.ts.stmpl @@ -93,7 +93,7 @@ export const startCommand = buildCommand({ {{- end}} parse: (value) => new URL(value).toString(), }, - {{- if $globalSDK.Servers}}{{if $serverMap}} + {{- if $hasServers}}{{if $serverMap}} {{- addImport "../../../lib/config.js" "ServerList" }} server: { kind: "enum", diff --git a/templates/templates/typescriptv2/mcp-server/cli/start/impl.ts.stmpl b/templates/templates/typescriptv2/mcp-server/cli/start/impl.ts.stmpl index bc05c3f6a..17e55a5f7 100644 --- a/templates/templates/typescriptv2/mcp-server/cli/start/impl.ts.stmpl +++ b/templates/templates/typescriptv2/mcp-server/cli/start/impl.ts.stmpl @@ -49,7 +49,7 @@ interface StartCommandFlags { {{- else }} readonly "server-url": string; {{- end}} - {{- if $globalSDK.Servers}}{{if $serverMap}} + {{- if $hasServers}}{{if $serverMap}} {{- addImport "../../../lib/config.js" "SDKOptions" }} readonly server?: SDKOptions["server"]; {{- else}} diff --git a/templates/templates/typescriptv2/mcp-server/create-mcp-server.ts.stmpl b/templates/templates/typescriptv2/mcp-server/create-mcp-server.ts.stmpl index 0a326aca5..3f563ac67 100644 --- a/templates/templates/typescriptv2/mcp-server/create-mcp-server.ts.stmpl +++ b/templates/templates/typescriptv2/mcp-server/create-mcp-server.ts.stmpl @@ -1,6 +1,7 @@ {{- $globalSDK := .Global.AST.MainSDK -}} {{- $globalSecurity := $globalSDK.Security }} {{- $serverMap := (and $globalSDK.Servers $globalSDK.Servers.ServerMap) -}} +{{- $hasServers := (and $globalSDK.Servers $globalSDK.Servers.HasAbsoluteURL) -}} {{ if .Local.Factory }}createMCPServerFactory{{ else }}createMCPServer{{ end }}({ logger, allowedTools: flags.tool, @@ -21,7 +22,7 @@ {{- end}} {{- end}}{{/* if ne $globalSDK.Globals nil */}} serverURL: flags["server-url"], - {{- if $globalSDK.Servers}} + {{- if $hasServers}} {{- if $serverMap}} server: flags.server, {{- else}} diff --git a/templates/templates/typescriptv2/mcp-server/server.ts.stmpl b/templates/templates/typescriptv2/mcp-server/server.ts.stmpl index 9ed3e84d2..99301aa43 100644 --- a/templates/templates/typescriptv2/mcp-server/server.ts.stmpl +++ b/templates/templates/typescriptv2/mcp-server/server.ts.stmpl @@ -39,7 +39,7 @@ export function createMCPServer(deps: { {{ $fieldName }}?: SDKOptions["{{$fieldName}}"] | undefined; {{- end}} {{- end}}{{/* if (ne $globalSDK.Globals nil) */}} - {{- if $globalSDK.Servers}}{{if $serverMap}} + {{- if $hasServers}}{{if $serverMap}} {{- addImport "../lib/config.js" "SDKOptions" }} server?: SDKOptions["server"] | undefined; {{- else}} @@ -77,7 +77,7 @@ export function createMCPServer(deps: { {{- end}} {{- end}}{{/* if (ne $globalSDK.Globals nil) */}} serverURL: deps.serverURL, - {{- if $globalSDK.Servers}}{{if $serverMap}} + {{- if $hasServers}}{{if $serverMap}} server: deps.server, {{- else}} serverIdx: deps.serverIdx,