ISC json is out of sync with XML

[cwege]

While https://github.com/spdx/license-list-XML/blob/main/src/ISC.xml contains the source for the ISC license correctly, the generated json at https://github.com/spdx/license-list-data/blob/main/json/details/ISC.json contains some copyright statements that should not be there. From what I read here they should be in sync. What is needed to bring them back to sync?

Thanks,

Christian Wege, christian.wege@mercedes-benz.com, Mercedes-Benz Group AG, https://group.mercedes-benz.com/provider/

[goneall]

There is an option where the text for the license will be picked up verbatim from the test file. The difference is likely due to this option being used during publication.

This option was added per a request to keep the optional text and formatting exactly the same as the original.

To put these back in sync, I would suggest creating a PR to modify the test file https://github.com/spdx/license-list-XML/blob/main/test/simpleTestForGenerator/ISC.txt

[xsuchy]

But... the licenses in test/simpleTestForGenerator/* are "just" test file. Not always canonical texts. There are likely dozens of licenses where there is specific copyright instead of general text matching <copyrightText>.
I would argue that the correct way is to generate licenseText in JSON from an XML file rather than from a test file.

[goneall]

@xsuchy - If we use the XML file for the license text, we would loose formatting since we don't include <br/> tags reliably for the linefeeds. This is the reason we went to pulling the text from the "test files".

Reference #83 and the associated issues which were closed when we introduced this "fix".

Note that there is a flag in the code which would make it easy to go back to using the XML text, but we would end up with several new issues.