From a8ba46aee16a02e241da0c012871792318bf4c80 Mon Sep 17 00:00:00 2001 From: Colby Nyce Date: Wed, 4 Mar 2026 06:38:40 -0800 Subject: [PATCH 1/2] Fix bug in getAppsInHookOrder_ --- include/simdb/apps/AppManager.hpp | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/include/simdb/apps/AppManager.hpp b/include/simdb/apps/AppManager.hpp index 983133e3..6d1be1d3 100644 --- a/include/simdb/apps/AppManager.hpp +++ b/include/simdb/apps/AppManager.hpp @@ -446,13 +446,19 @@ class AppManager } } } - for (const auto& [base, vec] : by_base) + + // Now append any apps that were not given explicit hook ordering + for (auto& [_, app] : apps_) { - for (App* app : vec) + if (std::find(out.begin(), out.end(), app.get()) == out.end()) { - out.push_back(app); + out.push_back(app.get()); } } + + assert(std::set(out.begin(), out.end()) == + std::set(getApps_().begin(), getApps_().end())); + return out; } From 1b6cb8865ab16a04e944506eff53d96b00b17e35 Mon Sep 17 00:00:00 2001 From: Colby Nyce Date: Wed, 4 Mar 2026 06:40:01 -0800 Subject: [PATCH 2/2] Run clang-format --- include/simdb/apps/AppManager.hpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/simdb/apps/AppManager.hpp b/include/simdb/apps/AppManager.hpp index 6d1be1d3..784626e3 100644 --- a/include/simdb/apps/AppManager.hpp +++ b/include/simdb/apps/AppManager.hpp @@ -456,8 +456,7 @@ class AppManager } } - assert(std::set(out.begin(), out.end()) == - std::set(getApps_().begin(), getApps_().end())); + assert(std::set(out.begin(), out.end()) == std::set(getApps_().begin(), getApps_().end())); return out; }