Skip to content

Clean up SmesherID #174

@lrettig

Description

@lrettig

We have contradictory types for smesherID:

message SmesherIDResponse {
AccountId account_id = 1;
}

and

message SmesherId {
bytes id = 1;
}

Unify these. Should the ID be bytes or AccountId?

Note that we define SmesherID in go-spacemesh to be a NodeID: https://github.com/spacemeshos/go-spacemesh/blob/d4c11da68a0521ec8e23da1f3fd4a4a25c32de94/activation/activation.go#L76

which gets turned into an address: https://github.com/spacemeshos/go-spacemesh/blob/d4c11da68a0521ec8e23da1f3fd4a4a25c32de94/api/grpcserver/smesher_service.go#L114

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions