Skip to content

Rename is_feedback_reflow — name semantics are confusing #228

@clkao

Description

@clkao

Problem

`claude-team build`'s dispatch JSON has an `is_feedback_reflow: true|false` field. The documented semantics are: "true only when routing a rejection back to its feedback-to target stage". The field name, however, reads naturally as "this entity has had any feedback cycle in its history" — which makes it easy to incorrectly set `true` when advancing forward after a completed feedback cycle.

I tripped on this once during a sprint; the helper correctly rejected. The error mode is subtle because the field name is plausible-looking either way.

Proposal

Rename to something that names the action, not the history. Candidates:

  • `routing_to_feedback_target: true`
  • `is_rejection_routing: true`
  • `route_back_to_feedback_stage: true`

Scale context

  • Spacedock version: 0.11.2
  • Workflow uses `feedback-to` wiring on validation -> implementation

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions