Backport fix for workspace globbing (#664)

See https://github.com/sourcegraph/sourcegraph/pull/28230 for more details.

Author: eseliger

CHANGELOG.md

@@ -21,6 +21,7 @@ All notable changes to `src-cli` are documented in this file.
 
 - Excess newlines in between outputs in logfiles written when `--keep-logs` is used have been fixed. [#665](https://github.com/sourcegraph/src-cli/pull/665)
 - `src` would sometimes panic when Ctrl-C was pressed while executing batch change steps due to a bug in the library used to render the execution progress bars. This has been fixed. [🤘 #666](https://github.com/sourcegraph/src-cli/pull/666)
+- In batch changes, when using `workspaces` src would incorrectly treat `in` not being set as _don't match anything_. This is fixed and it matches everything like `*`. [#664](https://github.com/sourcegraph/src-cli/pull/664)
 
 ### Removed
 

internal/batches/service/workspaces.go

@@ -43,9 +43,14 @@ func findWorkspaces(
 	// Pre-compile all globs.
 	workspaceMatchers := make(map[batcheslib.WorkspaceConfiguration]glob.Glob)
 	for _, conf := range spec.Workspaces {
-		g, err := glob.Compile(conf.In)
+		in := conf.In
+		// Empty `in` should fall back to matching all, instead of nothing.
+		if in == "" {
+			in = "*"
+		}
+		g, err := glob.Compile(in)
 		if err != nil {
-			return nil, batcheslib.NewValidationError(errors.Errorf("failed to compile glob %q: %v", conf.In, err))
+			return nil, batcheslib.NewValidationError(errors.Errorf("failed to compile glob %q: %v", in, err))
 		}
 		workspaceMatchers[conf] = g
 	}

internal/batches/service/workspaces_test.go

@@ -118,6 +118,24 @@ func TestFindWorkspaces(t *testing.T) {
 				{Repo: repos[2], Steps: steps, Path: "d/e/f", OnlyFetchWorkspace: true},
 			},
 		},
+		"workspace configuration without 'in' matches all": {
+			spec: &batcheslib.BatchSpec{
+				Steps: steps,
+				Workspaces: []batcheslib.WorkspaceConfiguration{
+					{
+						RootAtLocationOf: "package.json",
+					},
+				},
+			},
+			finderResults: finderResults{
+				repos[0]: {"a/b"},
+				repos[2]: {"a/b"},
+			},
+			wantWorkspaces: []RepoWorkspace{
+				{Repo: repos[0], Steps: steps, Path: "a/b"},
+				{Repo: repos[2], Steps: steps, Path: "a/b"},
+			},
+		},
 	}
 
 	for name, tt := range tests {