Skip to content

Commit 303d765

Browse files
authored
Fix "off by two" error when checking for args (#48)
I don't know how I previously came up with 4, but as it turns out if you run this src campaigns add-changesets -campaign='Q2FtcGFpZ246MQ==' -repo-name=github.com/sourcegraph/sourcegraph 33 44 55 66 The IDs `33` and `44` are ignored. This fixes the issue.
1 parent efadf0e commit 303d765

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

cmd/src/campaigns_add_changesets.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,11 @@ Notes:
5454
return &usageError{errors.New("-repo-name must be specified")}
5555
}
5656

57-
if len(args) <= 4 {
57+
if len(args) <= 2 {
5858
return &usageError{errors.New("no external changeset IDs specified")}
5959
}
6060

61-
externalIDs := args[4:]
61+
externalIDs := args[2:]
6262

6363
repoID, err := getRepoID(apiFlags, *repoNameFlag)
6464
if err != nil {

0 commit comments

Comments
 (0)