fix(plugin): detect symlinked monorepo sub-plugins in discoverPlugins (jackwener#487)

* fix(plugin): detect symlinked monorepo sub-plugins in discoverPlugins

discoverPlugins() used entry.isDirectory() to filter plugin directories,
but monorepo sub-plugins are installed as symlinks pointing into
~/.opencli/monorepos/. On most Node.js versions, isDirectory() returns
false for symlinks, causing monorepo plugin commands to be silently
skipped during discovery.

Add entry.isSymbolicLink() check so symlinked plugin directories are
properly discovered and their commands registered.

* fix(plugin): skip broken symlink discovery

---------

Co-authored-by: jackwener <jakevingoo@gmail.com>

Author: ByteYue

src/discovery.ts

@@ -196,8 +196,9 @@ export async function discoverPlugins(): Promise<void> {
   try { await fs.promises.access(PLUGINS_DIR); } catch { return; }
   const entries = await fs.promises.readdir(PLUGINS_DIR, { withFileTypes: true });
   for (const entry of entries) {
-    if (!entry.isDirectory()) continue;
-    await discoverPluginDir(path.join(PLUGINS_DIR, entry.name), entry.name);
+    const pluginDir = path.join(PLUGINS_DIR, entry.name);
+    if (!(await isDiscoverablePluginDir(entry, pluginDir))) continue;
+    await discoverPluginDir(pluginDir, entry.name);
   }
 }
 
@@ -246,3 +247,18 @@ async function isCliModule(filePath: string): Promise<boolean> {
     return false;
   }
 }
+
+async function isDiscoverablePluginDir(entry: fs.Dirent, pluginDir: string): Promise<boolean> {
+  if (entry.isDirectory()) return true;
+  if (!entry.isSymbolicLink()) return false;
+
+  try {
+    return (await fs.promises.stat(pluginDir)).isDirectory();
+  } catch (err) {
+    const code = (err as NodeJS.ErrnoException).code;
+    if (code !== 'ENOENT' && code !== 'ENOTDIR') {
+      log.warn(`Failed to inspect plugin link ${pluginDir}: ${getErrorMessage(err)}`);
+    }
+    return false;
+  }
+}

src/engine.test.ts

@@ -83,9 +83,15 @@ cli({
 describe('discoverPlugins', () => {
   const testPluginDir = path.join(PLUGINS_DIR, '__test-plugin__');
   const yamlPath = path.join(testPluginDir, 'greeting.yaml');
+  const symlinkTargetDir = path.join(os.tmpdir(), '__test-plugin-symlink-target__');
+  const symlinkPluginDir = path.join(PLUGINS_DIR, '__test-plugin-symlink__');
+  const brokenSymlinkDir = path.join(PLUGINS_DIR, '__test-plugin-broken__');
 
   afterEach(async () => {
     try { await fs.promises.rm(testPluginDir, { recursive: true }); } catch {}
+    try { await fs.promises.rm(symlinkPluginDir, { recursive: true, force: true }); } catch {}
+    try { await fs.promises.rm(symlinkTargetDir, { recursive: true, force: true }); } catch {}
+    try { await fs.promises.rm(brokenSymlinkDir, { recursive: true, force: true }); } catch {}
   });
 
   it('discovers YAML plugins from ~/.opencli/plugins/', async () => {
@@ -118,6 +124,38 @@ columns: [message]
     // discoverPlugins should not throw if ~/.opencli/plugins/ does not exist
     await expect(discoverPlugins()).resolves.not.toThrow();
   });
+
+  it('discovers YAML plugins from symlinked plugin directories', async () => {
+    await fs.promises.mkdir(PLUGINS_DIR, { recursive: true });
+    await fs.promises.mkdir(symlinkTargetDir, { recursive: true });
+    await fs.promises.writeFile(path.join(symlinkTargetDir, 'hello.yaml'), `
+site: __test-plugin-symlink__
+name: hello
+description: Test plugin greeting via symlink
+strategy: public
+browser: false
+
+pipeline:
+  - evaluate: "() => [{ message: 'hello from symlink plugin' }]"
+
+columns: [message]
+`);
+    await fs.promises.symlink(symlinkTargetDir, symlinkPluginDir, 'dir');
+
+    await discoverPlugins();
+
+    const cmd = getRegistry().get('__test-plugin-symlink__/hello');
+    expect(cmd).toBeDefined();
+    expect(cmd!.description).toBe('Test plugin greeting via symlink');
+  });
+
+  it('skips broken plugin symlinks without throwing', async () => {
+    await fs.promises.mkdir(PLUGINS_DIR, { recursive: true });
+    await fs.promises.symlink(path.join(os.tmpdir(), '__missing-plugin-target__'), brokenSymlinkDir, 'dir');
+
+    await expect(discoverPlugins()).resolves.not.toThrow();
+    expect(getRegistry().get('__test-plugin-broken__/hello')).toBeUndefined();
+  });
 });
 
 describe('executeCommand', () => {