Skip to content

Commit 287aa64

Browse files
committed
test: 삭제된 테스트와의 연관성 제거
- 삭제된 테스트 코드와 연관된 테스트 함수명, 구조 수정
1 parent 8dc0a09 commit 287aa64

2 files changed

Lines changed: 14 additions & 22 deletions

File tree

src/test/java/com/example/solidconnection/custom/security/filter/JwtAuthenticationFilterTest.java

Lines changed: 13 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.example.solidconnection.custom.security.filter;
22

33
import com.example.solidconnection.config.security.JwtProperties;
4-
import com.example.solidconnection.custom.security.authentication.ExpiredTokenAuthentication;
54
import com.example.solidconnection.custom.security.authentication.SiteUserAuthentication;
65
import com.example.solidconnection.custom.security.userdetails.SiteUserDetailsService;
76
import com.example.solidconnection.support.TestContainerSpringBootTest;
@@ -12,7 +11,6 @@
1211
import jakarta.servlet.http.HttpServletResponse;
1312
import org.junit.jupiter.api.BeforeEach;
1413
import org.junit.jupiter.api.DisplayName;
15-
import org.junit.jupiter.api.Nested;
1614
import org.junit.jupiter.api.Test;
1715
import org.springframework.beans.factory.annotation.Autowired;
1816
import org.springframework.boot.test.mock.mockito.MockBean;
@@ -36,7 +34,7 @@ class JwtAuthenticationFilterTest {
3634
@Autowired
3735
private JwtProperties jwtProperties;
3836

39-
@MockBean
37+
@MockBean // 이 테스트코드에서 사용자를 조회할 필요는 없으므로 MockBean 으로 대체
4038
private SiteUserDetailsService siteUserDetailsService;
4139

4240
private HttpServletRequest request;
@@ -63,25 +61,20 @@ void setUp() {
6361
then(filterChain).should().doFilter(request, response);
6462
}
6563

66-
@Nested
67-
class 토큰이_있으면_컨텍스트에_저장한다 {
68-
69-
@Test
70-
void 유효한_토큰을_컨텍스트에_저장한다() throws Exception {
71-
// given
72-
Date validExpiration = new Date(System.currentTimeMillis() + 1000);
73-
String token = createTokenWithExpiration(validExpiration);
74-
request = createRequestWithToken(token);
75-
76-
// when
77-
jwtAuthenticationFilter.doFilterInternal(request, response, filterChain);
64+
@Test
65+
void 토큰이_있으면_컨텍스트에_저장한다() throws Exception {
66+
// given
67+
Date validExpiration = new Date(System.currentTimeMillis() + 1000);
68+
String token = createTokenWithExpiration(validExpiration);
69+
request = createRequestWithToken(token);
7870

79-
// then
80-
assertThat(SecurityContextHolder.getContext().getAuthentication())
81-
.isExactlyInstanceOf(SiteUserAuthentication.class);
82-
then(filterChain).should().doFilter(request, response);
83-
}
71+
// when
72+
jwtAuthenticationFilter.doFilterInternal(request, response, filterChain);
8473

74+
// then
75+
assertThat(SecurityContextHolder.getContext().getAuthentication())
76+
.isExactlyInstanceOf(SiteUserAuthentication.class);
77+
then(filterChain).should().doFilter(request, response);
8578
}
8679

8780
private String createTokenWithExpiration(Date expiration) {

src/test/java/com/example/solidconnection/util/JwtUtilsTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
import java.util.Date;
1313

1414
import static com.example.solidconnection.util.JwtUtils.parseSubject;
15-
import static com.example.solidconnection.util.JwtUtils.parseSubjectIgnoringExpiration;
1615
import static com.example.solidconnection.util.JwtUtils.parseTokenFromRequest;
1716
import static org.assertj.core.api.Assertions.assertThat;
1817
import static org.assertj.core.api.Assertions.assertThatCode;
@@ -59,7 +58,7 @@ class 요청으로부터_토큰을_추출한다 {
5958
}
6059

6160
@Nested
62-
class 유효한_토큰으로부터_subject_를_추출한다 {
61+
class 토큰으로부터_subject_를_추출한다 {
6362

6463
@Test
6564
void 유효한_토큰의_subject_를_추출한다() {

0 commit comments

Comments
 (0)