SK-1909 Fix inconsistencies and issues in Python SDK v2

Author: skyflow-vivek

skyflow/error/_skyflow_error.py

@@ -8,7 +8,7 @@ def __init__(self,
                  request_id = None,
                  grpc_code = None,
                  http_status = None,
-                 details = None):
+                 details = []):
         self.message = message
         self.http_code = http_code
         self.grpc_code = grpc_code

skyflow/utils/_utils.py

@@ -359,7 +359,8 @@ def parse_invoke_connection_response(api_response: requests.Response):
 
             if error_from_client is not None:
                 if details is None: details = []
-                details.append({'error_from_client': error_from_client})
+                error_from_client_bool = error_from_client.lower() == 'true'
+                details.append({'error_from_client': error_from_client_bool})
 
             raise SkyflowError(message, status_code, request_id, grpc_code, http_status, details)
         except json.JSONDecodeError:
@@ -397,7 +398,7 @@ def handle_json_error(err, data, request_id, logger):
         status_code = description.get('error', {}).get('http_code', 500)  # Default to 500 if not found
         http_status = description.get('error', {}).get('http_status')
         grpc_code = description.get('error', {}).get('grpc_code')
-        details = description.get('error', {}).get('details')
+        details = description.get('error', {}).get('details', [])
 
         description_message = description.get('error', {}).get('message', "An unknown error occurred.")
         log_and_reject_error(description_message, status_code, request_id, http_status, grpc_code, details, logger = logger)

skyflow/vault/controller/_vault.py

@@ -43,8 +43,6 @@ def __build_batch_field_records(self, values, tokens, table_name, return_tokens,
                 upsert=upsert,
                 tokens=token
             )
-            if token is not None:
-                batch_record.tokens = token
             batch_record_list.append(batch_record)
         return batch_record_list
 

tests/vault/controller/test__connection.py

@@ -120,6 +120,6 @@ def test_parse_invoke_connection_response_error_from_client(self):
 
         exception = context.exception
 
-        self.assertTrue(any(detail.get('error_from_client') == 'true' for detail in exception.details))
+        self.assertTrue(any(detail.get('error_from_client') == True for detail in exception.details))
         self.assertEqual(exception.request_id, '12345')