Any change to the code needs to be proven by passing Unit/Integration tests. Developer(s) should add accompanying tests (of type either Unit or Systems Integration) to the set of changes in a PR. If a PR lacks the required tests, it should wait till all the tests are written before being merged into develop branch.
AppVeyor CI builds PRs and runs Unit tests. This step must be passed for PR before its merge.
Systems Integration tests(on Travi-CI) do not run on PRs and most likely a PR will be retargetted at another branch so maintainers can test the code before merging it into develop branch.
Before creating a pull request, make sure that your PR
- Has the latest commits from
developbranch - Targets
developbranch - Has a clear message saying why this PR
- References/Explains any related issues