fix(cli): sanitize the installer name by Unicode group, not by escape list

U+2028 and U+2029 are Zl/Zp, so the Cc/Cf filter let them through and a
deployment-controlled redirect filename could still forge a status line.

Enumerating what to strip had cost a patch per class found — C0 and C1, then
the bidi overrides, now the line separators — so this keeps whole groups
instead. `C` removes every control, format, surrogate, private-use, and
unassigned code point, covering ESC and OSC, the bidi overrides and isolates,
zero-width characters, and the BOM; `Z` removes every space, line, and
paragraph separator. Separators become a plain space rather than vanishing so
a name is not run together at the seam, and runs are collapsed so the result
cannot be padded to push text off the line.

The regression table now names each class that reached the terminal in an
earlier round, so a future bypass says which one came back.

Author: waleedlatif1

packages/sim-setup/src/desktop.test.ts

@@ -160,14 +160,28 @@ describe('sanitizeForTerminal', () => {
     expect(sanitizeForTerminal('Sim-1.2.3-universal.dmg')).toBe('Sim-1.2.3-universal.dmg')
   })
 
-  // Bidi overrides and isolates reorder what the reader sees without emitting a
-  // single control byte, so a range-based C0/C1 filter lets them straight
-  // through — `gpj.dmg` can be made to render as `dmg.jpg`.
-  it('strips bidi controls, not just cursor controls', () => {
-    expect(sanitizeForTerminal('Sim\u202e gmd.eno\u202c.dmg')).toBe('Sim gmd.eno.dmg')
-    for (const control of ['\u200e', '\u200f', '\u202a', '\u202d', '\u2066', '\u2069', '\u061c']) {
-      expect(sanitizeForTerminal(`a${control}b`)).toBe('ab')
-    }
+  // Every class that reached the terminal in an earlier round, kept as one
+  // table so a regression names which one came back. Enumerating escapes cost
+  // a patch per round, which is why the implementation strips whole Unicode
+  // groups rather than a list.
+  it.each([
+    ['bidi override', '\u202e', ''],
+    ['bidi isolate', '\u2066', ''],
+    ['bidi mark', '\u200e', ''],
+    ['arabic letter mark', '\u061c', ''],
+    ['zero-width space', '\u200b', ''],
+    ['byte-order mark', '\ufeff', ''],
+    ['line separator', '\u2028', ' '],
+    ['paragraph separator', '\u2029', ' '],
+    ['no-break space', '\u00a0', ' '],
+  ])('neutralizes a %s', (_name, character, expected) => {
+    expect(sanitizeForTerminal(`a${character}b`)).toBe(`a${expected}b`)
+  })
+
+  // Separators become a space rather than vanishing, so a name is not silently
+  // run together at the seam.
+  it('reduces a name built from several classes at once to printable text', () => {
+    expect(sanitizeForTerminal('Sim\u001b[2K\u202e\u2028\u00a0X.dmg')).toBe('Sim[2K X.dmg')
   })
 
   it('caps a name that would overrun the spinner line', () => {

packages/sim-setup/src/desktop.ts

@@ -41,18 +41,29 @@ function deploymentKey(value: string): string {
 const MAX_INSTALLER_NAME = 120
 
 /**
- * Strips anything that could move the cursor, repaint or retitle the terminal,
- * or reorder what the reader sees.
+ * Reduces an artifact name to printable text before it reaches a TTY.
  *
- * The artifact name is read out of a redirect the deployment chose, so it is
- * remote input on its way to a TTY, and `decodeURIComponent` turns percent-
- * encoded bytes into the real characters. Matched by Unicode class rather than
- * by hand-listed ranges: `Cc` covers C0 (including ESC), DEL, and C1, while
- * `Cf` covers the bidi overrides and isolates that would otherwise survive and
- * let a name render in an order it is not written in.
+ * The name is read out of a redirect the deployment chose, so it is remote
+ * input, and `decodeURIComponent` turns percent-encoded bytes into the real
+ * characters. Enumerating what to strip invited a patch per escape found — C0
+ * and C1, then the bidi overrides, then the line separators — so this keeps
+ * whole Unicode groups instead: `C` (Other) removes every control, format,
+ * surrogate, private-use, and unassigned code point, covering ESC and OSC, the
+ * bidi overrides and isolates, zero-width characters, and the BOM; `Z`
+ * (Separator) removes every space, line, and paragraph separator, covering
+ * U+2028/U+2029 and no-break spaces.
+ *
+ * Separators become a plain space rather than vanishing, so a name is not
+ * silently run together at the seam, and runs are collapsed so the result
+ * cannot be padded out to push text off the line.
  */
 export function sanitizeForTerminal(value: string): string {
-  return truncate(value.replace(/[\p{Cc}\p{Cf}]/gu, ''), MAX_INSTALLER_NAME)
+  const printable = value
+    .replace(/\p{C}/gu, '')
+    .replace(/\p{Z}/gu, ' ')
+    .replace(/ {2,}/g, ' ')
+    .trim()
+  return truncate(printable, MAX_INSTALLER_NAME)
 }
 
 export interface DesktopFlags {