fix(secrets): certify no sandbox exemptions once the registry is incomplete

Author: icecrasher321

apps/sim/app/api/credentials/route.test.ts

@@ -143,6 +143,7 @@ describe('GET /api/credentials', () => {
         type: 'env_personal',
         displayName: 'MY_API_KEY',
         description: null,
+        unredacted: false,
         providerId: null,
         accountId: null,
         envKey: 'MY_API_KEY',
@@ -186,6 +187,7 @@ describe('GET /api/credentials', () => {
         type: 'service_account',
         displayName: 'Slack custom bot',
         description: null,
+        unredacted: false,
         providerId: 'slack-custom-bot',
         accountId: null,
         envKey: null,
@@ -201,6 +203,7 @@ describe('GET /api/credentials', () => {
         type: 'oauth',
         displayName: 'Google account',
         description: null,
+        unredacted: false,
         providerId: 'google-email',
         accountId: 'google-account',
         envKey: null,
@@ -317,6 +320,7 @@ describe('POST /api/credentials', () => {
         type: 'service_account',
         displayName: 'Service account',
         description: null,
+        unredacted: false,
         providerId: 'zoom-service-account',
         accountId: null,
         envKey: null,
@@ -351,6 +355,7 @@ describe('POST /api/credentials', () => {
           type: 'service_account',
           displayName: 'Zoom account acct_123',
           description: null,
+          unredacted: false,
           providerId: 'zoom-service-account',
           accountId: null,
           envKey: null,
@@ -404,6 +409,7 @@ describe('POST /api/credentials', () => {
           type: 'service_account',
           displayName: 'Oracle NetSuite 1234567',
           description: null,
+          unredacted: false,
           providerId: 'netsuite-service-account',
           accountId: null,
           envKey: null,

apps/sim/executor/utils/resolved-secret-trace-registry.test.ts

@@ -2230,6 +2230,8 @@ describe('unredacted catalog exemption', () => {
     registry.markIncomplete('unspecified')
     expect(registry.getModelEgressSnapshot()).toEqual({ complete: false })
     expect(registry.exportProvenance().complete).toBe(false)
+    /** A missing collider is indistinguishable from none — certify nothing once latched. */
+    expect(registry.getUnredactedSecretNames()).toEqual([])
   })
 
   it('releases an exempt-only recorded input leaf to the model raw', async () => {

apps/sim/executor/utils/resolved-secret-trace-registry.ts

@@ -1791,8 +1791,14 @@ export class ResolvedSecretTraceRegistry {
    * sees only names and cannot re-check collisions itself, so any flagged name whose plaintext
    * another catalog entry or a non-exempt active entry shares is withheld — the file export
    * then records the colliding owner's provenance exactly as before.
+   *
+   * Certifies nothing once the registry is permanently incomplete: the collision set is built
+   * from the active entries, and a failed import or capacity latch means entries — including a
+   * collider for a flagged plaintext — may be missing. The same bar model egress applies, and
+   * for the same reason: incompleteness must only ever widen protection.
    */
   getUnredactedSecretNames(): readonly string[] {
+    if (this.isPermanentlyIncomplete()) return []
     const protectedPlaintexts = this.collectProtectedPlaintexts()
     const nonExemptCatalogPlaintexts = new Set<string>()
     for (const entry of this.catalog.values()) {