improvement(tools): state every pinned param, not just the credential

Two agent tools bound to the same Gmail account but different labels reached the
model byte-identical: every param a user fills is stripped from the schema, and
only the credential was ever named in the description. The model could not tell
Inbox from Sent, and with a single tool it could promise a caller it would search
a folder that tool can never reach.

Each tool now states the values the workflow pinned on it, whether or not it has
a duplicate sibling. Opaque resource ids still resolve to a display name; plain
values like a label, a row limit or a toggle need no lookup and are stated
directly. Secrets never are: a field marked `password`, a hidden field, a
secret-named param, and every literal on a tool whose params resolved an
environment variable are all withheld.

Author: waleedlatif1

apps/sim/executor/handlers/agent/agent-handler.ts

@@ -68,7 +68,7 @@ import type {
   ResolvedSecretInputPath,
   ResolvedSecretTraceRegistry,
 } from '@/executor/utils/resolved-secret-trace-registry'
-import { annotateDuplicateToolBindings } from '@/executor/utils/tool-binding-labels'
+import { annotateToolPinnedParams } from '@/executor/utils/tool-pinned-params'
 import { resolveVertexCredential } from '@/executor/utils/vertex-credential'
 import { executeProviderRequest } from '@/providers'
 import {
@@ -808,7 +808,11 @@ export class AgentBlockHandler implements BlockHandler {
     const tools = allTools.filter(
       (tool): tool is ProviderToolConfig => tool !== null && tool !== undefined
     )
-    await annotateDuplicateToolBindings(ctx, tools)
+    await annotateToolPinnedParams(ctx, tools, {
+      // A tool whose params resolved an environment secret must not have its literal values
+      // stated; the provenance map already identifies exactly those tools.
+      hasResolvedSecretInputs: (tool) => inputProvenance.has(tool),
+    })
     return { tools, inputProvenance }
   }
 

apps/sim/executor/handlers/pi/local/sim-tools.ts

@@ -16,7 +16,7 @@ import type { PiToolResult, PiToolSpec } from '@/executor/handlers/pi/core/backe
 import type { ExecutionContext } from '@/executor/types'
 import { projectResolvedSecretModelContent } from '@/executor/utils/resolved-secret-content-projection'
 import type { ResolvedSecretTraceRegistry } from '@/executor/utils/resolved-secret-trace-registry'
-import { annotateDuplicateToolBindings } from '@/executor/utils/tool-binding-labels'
+import { annotateToolPinnedParams } from '@/executor/utils/tool-pinned-params'
 import { assignProviderToolIdentities } from '@/providers/tool-identity'
 import type { ProviderToolConfig } from '@/providers/types'
 import { transformBlockTool } from '@/providers/utils'
@@ -233,7 +233,13 @@ export async function buildSimToolSpecs(
   }
 
   const providers = configuredTools.map(({ provider }) => provider)
-  await annotateDuplicateToolBindings(ctx, providers)
+  // Pi resolves secret provenance per tool CALL rather than per format, so it cannot say which
+  // individual tool carries one. Withhold literal values for the whole run when any input
+  // resolved a secret — coarse, but it errs toward stating less.
+  const runResolvedSecrets = Boolean(ctx.resolvedSecretTraceRegistry?.hasResolvedInputProjections())
+  await annotateToolPinnedParams(ctx, providers, {
+    hasResolvedSecretInputs: () => runResolvedSecrets,
+  })
   assignProviderToolIdentities(providers)
   return configuredTools.map(({ provider, toolIndex }) =>
     buildSimToolSpec(ctx, inputTools, provider, toolIndex)