Skip to content

Commit ec43e24

Browse files
committed
fix(vanta): drop the dead whenOperation from the removed-subblock entry
migrateBlockSubblockIds handles a _removed_ target before it consults whenOperation, so the scope was never applied. Mine was the only _removed_ entry in the file carrying one. Unconditional deletion is also what this case wants. Subblock values are keyed by id and are not cleared when the operation changes, so a user who filled the MIME field and then switched the block to another operation has the value stored under that operation; a scoped delete would strand it permanently. The field no longer exists for any operation, so it should go regardless of the stored operation.
1 parent 1f06127 commit ec43e24

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

apps/sim/lib/workflows/migrations/subblock-migrations.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -298,13 +298,7 @@ export const SUBBLOCK_ID_MIGRATIONS: Record<string, readonly SubblockIdMigration
298298
* that resolution is never empty, so the field's value lost the `||` chain every
299299
* time. Dropped rather than renamed — there is no field for the value to move to.
300300
*/
301-
vanta: [
302-
{
303-
from: 'uploadMimeType',
304-
to: '_removed_uploadMimeType',
305-
whenOperation: ['upload_document_file'],
306-
},
307-
],
301+
vanta: [{ from: 'uploadMimeType', to: '_removed_uploadMimeType' }],
308302
}
309303

310304
/** Reads the value out of a stored subblock entry, tolerating a bare value. */

0 commit comments

Comments
 (0)