Skip to content

Commit eb4a3d8

Browse files
committed
fix(sap_concur): drop the removed forwardId subblock via a migration
Removing the `forwardId` subblock without a migration entry breaks deployed workflows that still carry a value under that key. It fed a `concur-forwardid` request header that is documented nowhere in Concur's Receipts v4 or Image v1 references, so it was never honored. There is no replacement subblock and the value is an opaque caller-chosen string rather than a secret, so it is dropped outright.
1 parent d624b21 commit eb4a3d8

1 file changed

Lines changed: 9 additions & 0 deletions

File tree

apps/sim/lib/workflows/migrations/subblock-migrations.ts

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,15 @@ export const SUBBLOCK_ID_MIGRATIONS: Record<string, readonly SubblockIdMigration
283283
{ from: 'status', to: '_removed_status' },
284284
{ from: 'users', to: '_removed_users' },
285285
],
286+
/**
287+
* `forwardId` fed a `concur-forwardid` request header on the receipt upload.
288+
* That header is documented nowhere in Concur's Receipts v4 or Image v1
289+
* references, so it was never honored — the value rode along on every upload
290+
* and did nothing. There is no replacement subblock to carry it to, and the
291+
* value is an opaque caller-chosen string rather than a secret, so it is
292+
* dropped outright.
293+
*/
294+
sap_concur: [{ from: 'forwardId', to: '_removed_forwardId' }],
286295
}
287296

288297
/** Reads the value out of a stored subblock entry, tolerating a bare value. */

0 commit comments

Comments
 (0)