fix(tables): preserve explicit column undo metadata

Author: j15z

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx

@@ -25,7 +25,7 @@ import type {
   WorkflowGroup,
 } from '@/lib/table'
 import { getColumnId } from '@/lib/table/column-keys'
-import { columnTypeOf, typeMetadataOf } from '@/lib/table/column-types'
+import { columnTypeOf } from '@/lib/table/column-types'
 import { TABLE_LIMITS } from '@/lib/table/constants'
 import { cellValueFilterConditions } from '@/lib/table/query-builder/cell-filter'
 import { SEARCH_DEBOUNCE_MS } from '@/lib/url-state'
@@ -4124,7 +4124,14 @@ export function TableGrid({
             columnPosition: adjustedPosition >= 0 ? adjustedPosition : cols.length,
             columnUnique: entry.def?.unique ?? false,
             columnRequired: entry.def?.required ?? false,
-            columnTypeMetadata: entry.def ? typeMetadataOf(entry.def) : {},
+            // Without these a deleted select column can't be re-created — it is
+            // invalid with no options, and the saved cell data is option ids.
+            ...(entry.def?.options ? { columnOptions: entry.def.options } : {}),
+            ...(entry.def?.multiple ? { columnMultiple: true } : {}),
+            ...(entry.def?.currencyCode ? { columnCurrencyCode: entry.def.currencyCode } : {}),
+            ...(entry.def?.referenceTableId
+              ? { columnReferenceTableId: entry.def.referenceTableId }
+              : {}),
             cellData,
             previousOrder: orderSnapshot,
             previousWidth,

apps/sim/hooks/use-table-undo.test.ts

@@ -195,7 +195,6 @@ describe('useTableUndo – delete-column undo cell restore chunking', () => {
     columnPosition: 0,
     columnUnique: false,
     columnRequired: false,
-    columnTypeMetadata: {},
     cellData: [],
     previousOrder: null,
     previousWidth: null,
@@ -249,10 +248,8 @@ describe('useTableUndo – restoring a deleted select column', () => {
     columnPosition: 0,
     columnUnique: false,
     columnRequired: false,
-    columnTypeMetadata: {
-      options: [{ id: 'opt_open', name: 'Open' }],
-      multiple: true,
-    },
+    columnOptions: [{ id: 'opt_open', name: 'Open' }],
+    columnMultiple: true,
     cellData: [],
     previousOrder: null,
     previousWidth: null,
@@ -276,6 +273,41 @@ describe('useTableUndo – restoring a deleted select column', () => {
   })
 })
 
+describe('useTableUndo – restoring a deleted currency column', () => {
+  it('re-creates the column with its original denomination', async () => {
+    mockPopUndo.mockReturnValueOnce(
+      makeEntry({
+        type: 'delete-column',
+        columnName: 'amount',
+        columnId: 'col_amount',
+        columnType: 'currency',
+        columnPosition: 0,
+        columnUnique: false,
+        columnRequired: false,
+        columnCurrencyCode: 'JPY',
+        cellData: [],
+        previousOrder: null,
+        previousWidth: null,
+        previousPinnedColumns: null,
+      })
+    )
+
+    const { undo } = TestHook()
+    ;(undo as () => void)()
+    await flush()
+
+    expect(mockMutate).toHaveBeenCalledWith(
+      expect.objectContaining({
+        id: 'col_amount',
+        name: 'amount',
+        type: 'currency',
+        currencyCode: 'JPY',
+      }),
+      expect.any(Object)
+    )
+  })
+})
+
 describe('useTableUndo – restoring a deleted reference column', () => {
   it('re-creates the column with its target table', async () => {
     mockPopUndo.mockReturnValueOnce(
@@ -287,7 +319,7 @@ describe('useTableUndo – restoring a deleted reference column', () => {
         columnPosition: 0,
         columnUnique: false,
         columnRequired: false,
-        columnTypeMetadata: { referenceTableId: 'tbl_people' },
+        columnReferenceTableId: 'tbl_people',
         cellData: [],
         previousOrder: null,
         previousWidth: null,

apps/sim/hooks/use-table-undo.ts

@@ -386,7 +386,12 @@ export function useTableUndo({
                   type: action.columnType,
                   required: action.columnRequired,
                   unique: action.columnUnique,
-                  ...action.columnTypeMetadata,
+                  ...(action.columnOptions ? { options: action.columnOptions } : {}),
+                  ...(action.columnMultiple ? { multiple: true } : {}),
+                  ...(action.columnCurrencyCode ? { currencyCode: action.columnCurrencyCode } : {}),
+                  ...(action.columnReferenceTableId
+                    ? { referenceTableId: action.columnReferenceTableId }
+                    : {}),
                   position: action.columnPosition,
                 },
                 {

apps/sim/stores/table/store.test.ts

@@ -19,7 +19,6 @@ const deleteColumn: TableUndoAction = {
   columnPosition: 0,
   columnUnique: false,
   columnRequired: false,
-  columnTypeMetadata: {},
   cellData: [],
   previousOrder: ['a', 'b'],
   previousWidth: null,

apps/sim/stores/table/types.ts

@@ -55,7 +55,15 @@ export type TableUndoAction =
       columnPosition: number
       columnUnique: boolean
       columnRequired: boolean
-      columnTypeMetadata: Partial<ColumnDefinition>
+      // A `select` column is invalid without its option set, so the snapshot has
+      // to carry it or the restore is rejected — and the saved cell data, which
+      // holds option ids, would have nothing to attach to.
+      columnOptions?: ColumnDefinition['options']
+      columnMultiple?: boolean
+      // Likewise for a `currency` column: without its code the restore would
+      // silently re-denominate every cell to the default currency.
+      columnCurrencyCode?: string
+      columnReferenceTableId?: string
       cellData: Array<{ rowId: string; value: unknown }>
       previousOrder: string[] | null
       previousWidth: number | null