fix(platform): give embedded choice menus their bare label

ChoiceMenu appends the selection to its label, so the embedded Search filters and the
Search MCP app picker announced it twice ("Filter by source: All sources: All sources").
Pass the bare label as the zone does, and drive the Search and member-role checks through
the menu button and radio items that replaced the comboboxes.

Author: waleedlatif1

apps/sim/platform/embedded/app/(shell)/_components/search/search-results.tsx

@@ -24,15 +24,15 @@ function SearchFilterControls({ sourceTypes }: { sourceTypes: readonly string[]
     <div className={styles.filters} role='group' aria-label='Search filters'>
       <div className={styles.filter}>
         <ChoiceMenu
-          label={source.label}
+          label='Filter by source'
           value={source.value}
           options={source.options}
           onValueChange={source.onChange}
         />
       </div>
       <div className={styles.filter}>
         <ChoiceMenu
-          label={updated.label}
+          label='Filter by date'
           value={updated.value}
           options={updated.options}
           onValueChange={updated.onChange}

apps/sim/platform/embedded/app/(shell)/settings/_components/sections/search-mcp/search-mcp-section.tsx

@@ -99,7 +99,7 @@ export default function SearchMcpSection({ organization }: SettingsSectionProps)
         <>
           <SettingsRow label='App'>
             <ChoiceMenu
-              label={`MCP app: ${client.label}`}
+              label='MCP app'
               value={client.value}
               options={CLIENTS}
               onValueChange={(value) => {

apps/sim/scripts/org-redesign-e2e/checks/search.ts

@@ -114,10 +114,10 @@ export async function searchChecks() {
       const links = page.locator('a[data-source-link]')
       await expect(links.first()).toHaveAttribute('target', '_blank')
       const filters = page.getByRole('group', { name: 'Search filters' })
-      await filters.getByRole('combobox', { name: /Filter by date/ }).click()
-      await page.getByRole('option', { name: 'Past week' }).click()
+      await filters.getByRole('button', { name: /Filter by date/ }).click()
+      await page.getByRole('menuitemradio', { name: 'Past week' }).click()
       await expect(page).toHaveURL((address) => address.searchParams.get('updated') === '7d')
-      await filters.getByRole('combobox', { name: /Filter by source/ }).click()
+      await filters.getByRole('button', { name: /Filter by source/ }).click()
       await page.keyboard.press('Escape')
       await links.first().focus()
       await page.keyboard.press('ArrowDown')

apps/sim/scripts/org-redesign-e2e/checks/settings.ts

@@ -626,15 +626,15 @@ export async function settingsChecks() {
       () =>
         withSession(ADMIN, async ({ page }) => {
           await page.goto(orgUrl('/settings/members'))
-          const role = page.getByRole('combobox', { name: 'Role for Mia Member', exact: true })
+          const role = page.getByRole('button', { name: /^Role for Mia Member: / })
           const set = async (name: string) => {
             const write = page.waitForResponse(
               (response) =>
                 /\/api\/organizations\/[^/]+\/members\/[^/]+$/.test(pathOf(response.url())) &&
                 response.request().method() !== 'GET'
             )
             await role.click()
-            await page.getByRole('option', { name, exact: true }).click()
+            await page.getByRole('menuitemradio', { name, exact: true }).click()
             assert.ok((await write).ok(), `Setting ${name} failed`)
             await expect(role).toContainText(name)
           }

apps/sim/scripts/test-organization-search-e2e.ts

@@ -932,9 +932,9 @@ try {
         )
         await expect(wikiResult).toBeVisible()
         await capture('search-populated-desktop')
-        await page.getByRole('combobox', { name: 'Filter by source: All sources' }).click()
+        await page.getByRole('button', { name: 'Filter by source: All sources' }).click()
         await capture('search-source-filter')
-        await page.getByRole('option', { name: 'Google Drive', exact: true }).click()
+        await page.getByRole('menuitemradio', { name: 'Google Drive', exact: true }).click()
         await expect(page).toHaveURL((url) => url.searchParams.get('source') === 'google_drive')
         await expect(wikiResult).toHaveCount(0)
         await capture('search-filtered')