fix(slack): preserve optional pagination defaults

Author: TheodoreSpeaks

apps/sim/blocks/blocks/slack.test.ts

@@ -212,5 +212,8 @@ describe('Slack block release', () => {
     expect(() => mapSlackV2Params({ ...values, channelMaxPages: '11' })).toThrow(
       'Max pages must be an integer between 1 and 10'
     )
+    expect(mapSlackV2Params({ ...values, channelLimit: null, channelMaxPages: ' ' })).toMatchObject(
+      { limit: 100 }
+    )
   })
 })

apps/sim/blocks/blocks/slack.ts

@@ -2140,13 +2140,20 @@ Return ONLY the integer Unix timestamp - no explanations, no quotes, no extra te
           case 'list_channels': {
             baseParams.includePrivate = includePrivate !== 'false'
             baseParams.excludeArchived = true
-            const parsedLimit =
-              channelLimit === undefined || channelLimit === '' ? 100 : Number(channelLimit)
+            const hasChannelLimit =
+              channelLimit !== undefined &&
+              channelLimit !== null &&
+              (typeof channelLimit !== 'string' || Boolean(channelLimit.trim()))
+            const parsedLimit = hasChannelLimit ? Number(channelLimit) : 100
             if (!Number.isInteger(parsedLimit) || parsedLimit < 1 || parsedLimit > 200) {
               throw new Error('Conversations per page must be an integer between 1 and 200')
             }
             baseParams.limit = parsedLimit
-            if (channelMaxPages !== undefined && channelMaxPages !== '') {
+            const hasChannelMaxPages =
+              channelMaxPages !== undefined &&
+              channelMaxPages !== null &&
+              (typeof channelMaxPages !== 'string' || Boolean(channelMaxPages.trim()))
+            if (hasChannelMaxPages) {
               const parsedMaxPages = Number(channelMaxPages)
               if (!Number.isInteger(parsedMaxPages) || parsedMaxPages < 1 || parsedMaxPages > 10) {
                 throw new Error('Max pages must be an integer between 1 and 10')

apps/sim/lib/internal/slack/operations/list-conversations.ts

@@ -80,7 +80,9 @@ function resolveBoundedInteger(
   label: string,
   maximum: number
 ): number {
-  if (value === undefined) return defaultValue
+  if (value === undefined || value === null || (typeof value === 'string' && !value.trim())) {
+    return defaultValue
+  }
   const parsed = Number(value)
   if (!Number.isInteger(parsed) || parsed < 1 || parsed > maximum) {
     throw new Error(`${label} must be an integer between 1 and ${maximum}`)

apps/sim/tools/slack/list_channels.test.ts

@@ -191,6 +191,20 @@ describe('Slack list channels', () => {
     expect(fetchMock).not.toHaveBeenCalled()
   })
 
+  it('uses defaults for unresolved optional pagination values', async () => {
+    fetchMock.mockResolvedValueOnce(
+      slackResponse({ ok: true, channels: [], response_metadata: { next_cursor: '' } })
+    )
+
+    await executeSlackListConversationsOperation({
+      ...BASE_PARAMS,
+      limit: null as never,
+      maxPages: ' ' as never,
+    })
+
+    expect(new URL(String(fetchMock.mock.calls[0]?.[0])).searchParams.get('limit')).toBe('100')
+  })
+
   it('fails fast on malformed successful responses and repeated cursors', async () => {
     fetchMock.mockResolvedValueOnce(slackResponse({ ok: true }))
     await expect(executeSlackListConversationsOperation(BASE_PARAMS)).rejects.toThrow(