fix(jsm): cap pagination at the documented int32 maximum

Addresses review: the schema claimed the int32 range but only floored at 0,
so values above 2147483647 were forwarded to Atlassian instead of being
rejected at Sim's boundary. Also restores the const tuple for the paginated
operation list and drops the widened ToolConfig from the test table.

Author: waleedlatif1

apps/sim/blocks/blocks/jira_service_management.test.ts

@@ -29,97 +29,81 @@ import {
   jsmGetSlaTool,
   jsmGetTransitionsTool,
 } from '@/tools/jsm'
-import type { ToolConfig } from '@/tools/types'
+import type { ToolConfig, ToolResponse } from '@/tools/types'
 
 const DOMAIN = 'example.atlassian.net'
 /** Injected by the executor from the OAuth credential before the tool's `body` runs. */
 const ACCESS_TOKEN = 'token-123'
 
 interface PaginatedCase {
   operation: string
-  tool: ToolConfig<any, any>
+  toolId: string
+  /** The tool's own `request.body`, captured at its concrete param type by `paginatedCase`. */
+  buildBody: (params: Record<string, unknown>) => Record<string, unknown>
   schema: z.ZodType
   extraInputs: Record<string, string>
 }
 
+/**
+ * Captures each tool at its own generic so an incompatible tool/contract pairing is still a type
+ * error at the call site, rather than being erased by a widened `ToolConfig` in the table type.
+ */
+function paginatedCase<P, R extends ToolResponse>(
+  operation: string,
+  tool: ToolConfig<P, R>,
+  schema: z.ZodType,
+  extraInputs: Record<string, string> = {}
+): PaginatedCase {
+  return {
+    operation,
+    toolId: tool.id,
+    buildBody: (params) => {
+      const bodyFn = tool.request.body
+      if (!bodyFn) throw new Error(`${tool.id} is missing request.body`)
+      return bodyFn(params as P) as Record<string, unknown>
+    },
+    schema,
+    extraInputs,
+  }
+}
+
 /**
  * Every paginated JSM operation, wired to the tool it resolves to and the contract its route
  * parses the body with. This walks the real chain — block `tools.config.params` → the tool's
  * `request.body` → the route contract — which is exactly where `jsm_get_comments` broke: the
  * tools declare `start`/`limit` as `type: 'number'` while the contract demanded strings.
  */
 const PAGINATED_CASES: PaginatedCase[] = [
-  {
-    operation: 'get_service_desks',
-    tool: jsmGetServiceDesksTool,
-    schema: jsmServiceDesksBodySchema,
-    extraInputs: {},
-  },
-  {
-    operation: 'get_request_types',
-    tool: jsmGetRequestTypesTool,
-    schema: jsmRequestTypesToolBodySchema,
-    extraInputs: { serviceDeskId: '1' },
-  },
-  {
-    operation: 'get_requests',
-    tool: jsmGetRequestsTool,
-    schema: jsmRequestsBodySchema,
-    extraInputs: {},
-  },
-  {
-    operation: 'get_comments',
-    tool: jsmGetCommentsTool,
-    schema: jsmCommentsBodySchema,
-    extraInputs: { issueIdOrKey: 'SD-123' },
-  },
-  {
-    operation: 'get_customers',
-    tool: jsmGetCustomersTool,
-    schema: jsmCustomersBodySchema,
-    extraInputs: { serviceDeskId: '1' },
-  },
-  {
-    operation: 'get_organizations',
-    tool: jsmGetOrganizationsTool,
-    schema: jsmServiceDeskScopedBodySchema,
-    extraInputs: { serviceDeskId: '1' },
-  },
-  {
-    operation: 'get_queues',
-    tool: jsmGetQueuesTool,
-    schema: jsmQueuesBodySchema,
-    extraInputs: { serviceDeskId: '1' },
-  },
-  {
-    operation: 'get_sla',
-    tool: jsmGetSlaTool,
-    schema: jsmIssuePaginationBodySchema,
-    extraInputs: { issueIdOrKey: 'SD-123' },
-  },
-  {
-    operation: 'get_transitions',
-    tool: jsmGetTransitionsTool,
-    schema: jsmIssuePaginationBodySchema,
-    extraInputs: { issueIdOrKey: 'SD-123' },
-  },
-  {
-    operation: 'get_participants',
-    tool: jsmGetParticipantsTool,
-    schema: jsmParticipantsBodySchema,
-    extraInputs: { issueIdOrKey: 'SD-123' },
-  },
-  {
-    operation: 'get_approvals',
-    tool: jsmGetApprovalsTool,
-    schema: jsmApprovalsBodySchema,
-    extraInputs: { issueIdOrKey: 'SD-123' },
-  },
+  paginatedCase('get_service_desks', jsmGetServiceDesksTool, jsmServiceDesksBodySchema),
+  paginatedCase('get_request_types', jsmGetRequestTypesTool, jsmRequestTypesToolBodySchema, {
+    serviceDeskId: '1',
+  }),
+  paginatedCase('get_requests', jsmGetRequestsTool, jsmRequestsBodySchema),
+  paginatedCase('get_comments', jsmGetCommentsTool, jsmCommentsBodySchema, {
+    issueIdOrKey: 'SD-123',
+  }),
+  paginatedCase('get_customers', jsmGetCustomersTool, jsmCustomersBodySchema, {
+    serviceDeskId: '1',
+  }),
+  paginatedCase('get_organizations', jsmGetOrganizationsTool, jsmServiceDeskScopedBodySchema, {
+    serviceDeskId: '1',
+  }),
+  paginatedCase('get_queues', jsmGetQueuesTool, jsmQueuesBodySchema, { serviceDeskId: '1' }),
+  paginatedCase('get_sla', jsmGetSlaTool, jsmIssuePaginationBodySchema, { issueIdOrKey: 'SD-123' }),
+  paginatedCase('get_transitions', jsmGetTransitionsTool, jsmIssuePaginationBodySchema, {
+    issueIdOrKey: 'SD-123',
+  }),
+  paginatedCase('get_participants', jsmGetParticipantsTool, jsmParticipantsBodySchema, {
+    issueIdOrKey: 'SD-123',
+  }),
+  paginatedCase('get_approvals', jsmGetApprovalsTool, jsmApprovalsBodySchema, {
+    issueIdOrKey: 'SD-123',
+  }),
 ]
 
 /** Run a set of block inputs through `tools.config.params`, then through the tool's request body. */
 function buildRequestBody(
-  { operation, tool, extraInputs }: PaginatedCase,
+  { operation, buildBody, extraInputs }: PaginatedCase,
   pagination: Record<string, string>
 ) {
   const paramsFn = JiraServiceManagementBlock.tools.config?.params
@@ -133,22 +117,16 @@ function buildRequestBody(
     ...pagination,
   })
 
-  const bodyFn = tool.request.body
-  if (!bodyFn) throw new Error(`${tool.id} is missing request.body`)
-
-  return bodyFn({ ...toolParams, accessToken: ACCESS_TOKEN, domain: DOMAIN }) as Record<
-    string,
-    unknown
-  >
+  return buildBody({ ...toolParams, accessToken: ACCESS_TOKEN, domain: DOMAIN })
 }
 
 describe.each(PAGINATED_CASES.map((testCase) => [testCase.operation, testCase] as const))(
   'JiraServiceManagementBlock %s',
   (_operation, testCase) => {
     it('resolves to the expected tool', () => {
       const toolFn = JiraServiceManagementBlock.tools.config?.tool
-      expect(toolFn?.({ operation: testCase.operation })).toBe(testCase.tool.id)
-      expect(JiraServiceManagementBlock.tools.access).toContain(testCase.tool.id)
+      expect(toolFn?.({ operation: testCase.operation })).toBe(testCase.toolId)
+      expect(JiraServiceManagementBlock.tools.access).toContain(testCase.toolId)
     })
 
     it('sends a body its route contract accepts when pagination is filled in', () => {

apps/sim/blocks/blocks/jira_service_management.ts

@@ -6,7 +6,7 @@ import type { JsmResponse } from '@/tools/jsm/types'
 import { getTrigger } from '@/triggers'
 
 /** Operations that accept Atlassian's `start`/`limit` pagination query params. */
-const PAGINATED_OPERATIONS: string[] = [
+const PAGINATED_OPERATIONS = [
   'get_service_desks',
   'get_request_types',
   'get_requests',
@@ -18,7 +18,7 @@ const PAGINATED_OPERATIONS: string[] = [
   'get_transitions',
   'get_participants',
   'get_approvals',
-]
+] as const
 
 /**
  * Coerce an optional numeric block input into an integer, returning undefined for
@@ -604,15 +604,15 @@ Return ONLY the comment text - no explanations.`,
       type: 'short-input',
       placeholder: 'Pagination start index (default: 0)',
       mode: 'advanced',
-      condition: { field: 'operation', value: PAGINATED_OPERATIONS },
+      condition: { field: 'operation', value: [...PAGINATED_OPERATIONS] },
     },
     {
       id: 'maxResults',
       title: 'Max Results',
       type: 'short-input',
       placeholder: 'Maximum results (default: 50)',
       mode: 'advanced',
-      condition: { field: 'operation', value: PAGINATED_OPERATIONS },
+      condition: { field: 'operation', value: [...PAGINATED_OPERATIONS] },
     },
     {
       id: 'assetSchemaId',

apps/sim/lib/api/contracts/selectors/jsm.test.ts

@@ -63,6 +63,9 @@ describe('JSM contract pagination', () => {
     expect(() => jsmCommentsBodySchema.parse({ ...body, limit: 2.5 })).toThrow()
     expect(() => jsmCommentsBodySchema.parse({ ...body, start: -1 })).toThrow()
     expect(() => jsmCommentsBodySchema.parse({ ...body, limit: Number.NaN })).toThrow()
+    expect(() => jsmCommentsBodySchema.parse({ ...body, limit: 2147483648 })).toThrow()
+    expect(jsmCommentsBodySchema.parse({ ...body, limit: 2147483647 }).limit).toBe('2147483647')
+    expect(jsmCommentsBodySchema.parse({ ...body, start: 0 }).start).toBe('0')
   })
 
   /**

apps/sim/lib/api/contracts/selectors/jsm.ts

@@ -40,7 +40,8 @@ const jsmPaginationField = z
     z
       .number()
       .int('Pagination values must be whole numbers')
-      .min(0, 'Pagination values must be 0 or greater'),
+      .min(0, 'Pagination values must be 0 or greater')
+      .max(2147483647, 'Pagination values must be within the int32 range'),
   ])
   .transform((value) => String(value))
   .optional()