cli updates

Author: Sg312

packages/sim-cli/README.md

@@ -126,6 +126,10 @@ sim chats list [--search <text>] [--limit <n>]
 sim chats get <chatId> [--read-only]
 sim chats rename <chatId> --title <title>
 
+sim secrets list [--scope workspace|personal]
+sim secrets set <name> --scope workspace|personal [--value <value> | --value-stdin]
+sim secrets delete <name> --scope workspace|personal --yes
+
 sim workflows ls [path] [--search <text>] [--limit <n>]
 sim workflows list [--folder <path>] [--deployed-only] [--limit <n>]
 sim workflows get <id>
@@ -195,6 +199,18 @@ Organization audit logs require a personal API key. Commands with
 Saved chat commands also require a personal API key and use that active
 workspace unless `--workspace` overrides it.
 
+`sim secrets set` prompts for the value without echoing it when run in an
+interactive terminal. For automation, pipe the value with `--value-stdin`; one
+trailing line ending is removed. The older inline `--value` form remains
+available, but can expose the value in shell history and process listings.
+Sensitive values are sent only to HTTPS profiles; HTTP is accepted only for
+localhost/loopback development endpoints.
+
+```bash
+sim secrets set OPENAI_API_KEY --scope workspace
+sim secrets set OPENAI_API_KEY --scope workspace --value-stdin < "$OPENAI_API_KEY_FILE"
+```
+
 `workflows runs get` is the lightweight status and polling resource.
 `--workflow` names the parent resource, while the run ID remains positional.
 For a paused run, its status includes the context ID needed by `resume`.
@@ -215,6 +231,13 @@ Structured questions use a separate compact panel: Up/Down moves, Enter selects,
 Space toggles multi-select items, typing supplies a custom answer, and Esc returns
 to the ordinary composer. Suggested follow-up metadata is omitted.
 
+OAuth requests show the validated Sim authorization URL directly so the terminal
+can open it in a browser. When Sim requests an environment secret, interactive
+chat presents a fixed-width masked input after the response finishes and saves
+the value through the write-only secrets API; the value never enters the chat
+composer or transcript. Enter saves and Esc skips. Read-only chat never opens a
+secret input and instead prints the secure `sim secrets set` command to run later.
+
 The composer stays editable while Sim is working. Press Enter with a follow-up
 to queue it and immediately steer the active turn (the TUI performs the web
 chat's queue-then-send-now handoff in one step); additional submitted prompts

packages/sim-cli/src/commands/protocol/chat-structured.test.ts

@@ -300,14 +300,102 @@ describe('renderChatStructured', () => {
     expect(controlBearing.text).not.toContain(ESC)
   })
 
-  it('renders credential links as a plain action without exposing the destination', () => {
+  it('renders only same-origin Sim credential links as visible destinations', () => {
+    const callbackUrl = encodeURIComponent('https://sim.example/workspace/ws-1')
+    const trusted = renderChatStructured(
+      `<credential>{"type":"link","provider":"Slack","value":"https://sim.example/api/auth/oauth2/authorize?providerId=slack&workspaceId=ws-1&callbackURL=${callbackUrl}"}</credential>`,
+      { simEndpoint: 'https://sim.example', workspaceId: 'ws-1' }
+    )
+    const lookalike = renderChatStructured(
+      '<credential>{"type":"link","provider":"Slack","value":"https://sim.example.evil.test/connect"}</credential>',
+      { simEndpoint: 'https://sim.example', workspaceId: 'ws-1' }
+    )
+
+    expect(trusted.text).toBe(
+      `Connect Slack in Sim:\nhttps://sim.example/api/auth/oauth2/authorize?providerId=slack&workspaceId=ws-1&callbackURL=${callbackUrl}`
+    )
+    expect(lookalike.text).toBe('Open Sim to connect Slack.')
+    expect(lookalike.text).not.toContain('sim.example.evil.test')
+    expect(trusted.text).not.toContain(ESC)
+    expect(lookalike.text).not.toContain(ESC)
+  })
+
+  it('rejects same-origin non-auth links, remote HTTP, and links for another workspace', () => {
+    const options = { simEndpoint: 'https://sim.example', workspaceId: 'ws-1' }
+    const wrongPath = renderChatStructured(
+      '<credential>{"type":"link","provider":"Slack","value":"https://sim.example/workspace/ws-1/settings"}</credential>',
+      options
+    )
+    const remoteHttp = renderChatStructured(
+      '<credential>{"type":"link","provider":"Slack","value":"http://sim.example/api/auth/trello/authorize"}</credential>',
+      { simEndpoint: 'http://sim.example', workspaceId: 'ws-1' }
+    )
+    const wrongWorkspace = renderChatStructured(
+      '<credential>{"type":"link","provider":"Slack","value":"https://sim.example/api/auth/oauth2/authorize?providerId=slack&workspaceId=ws-2&callbackURL=https%3A%2F%2Fsim.example%2Fworkspace%2Fws-2"}</credential>',
+      options
+    )
+
+    expect(wrongPath.text).toBe('Open Sim to connect Slack.')
+    expect(remoteHttp.text).toBe('Open Sim to connect Slack.')
+    expect(wrongWorkspace.text).toBe('Open Sim to connect Slack.')
+  })
+
+  it('accepts exact browser-auth routes, including HTTP on localhost only', () => {
+    const trello = renderChatStructured(
+      '<credential>{"type":"link","provider":"Trello","value":"http://localhost:3000/api/auth/trello/authorize"}</credential>',
+      { simEndpoint: 'http://localhost:3000', workspaceId: 'ws-1' }
+    )
+    const instagram = renderChatStructured(
+      '<credential>{"type":"link","provider":"Instagram","value":"https://sim.example/api/auth/instagram/authorize?returnUrl=https%3A%2F%2Fsim.example%2Fworkspace%2Fws-1%2Fchat%2Fchat-1&workspaceId=ws-1"}</credential>',
+      { simEndpoint: 'https://sim.example', workspaceId: 'ws-1' }
+    )
+
+    expect(trello.text).toContain('http://localhost:3000/api/auth/trello/authorize')
+    expect(instagram.text).toContain('https://sim.example/api/auth/instagram/authorize?')
+  })
+
+  it('turns secret inputs into interactive controls without putting a value in chat text', () => {
     const content =
-      '<credential>{"type":"link","provider":"Slack","value":"https://sim.example.evil.test/connect"}</credential>'
-    const result = renderChatStructured(content)
+      '<credential>{"type":"secret_input","name":"OPENAI_API_KEY","scope":"personal"}</credential>'
+    const interactive = renderChatStructured(content, { printMode: false })
+    const readOnly = renderChatStructured(content, {
+      printMode: false,
+      allowSecretInput: false,
+    })
+    const printable = renderChatStructured(content)
+
+    expect(interactive.text).toBe('')
+    expect(interactive.interactions).toEqual([
+      {
+        kind: 'credential',
+        credential: {
+          type: 'secret_input',
+          name: 'OPENAI_API_KEY',
+          scope: 'personal',
+          provider: undefined,
+        },
+      },
+    ])
+    expect(printable.text).toBe(
+      'Provide OPENAI_API_KEY securely with: sim secrets set OPENAI_API_KEY --scope personal'
+    )
+    expect(readOnly.interactions).toEqual([])
+    expect(readOnly.text).toBe(printable.text)
+  })
 
-    expect(result.text).toBe('Open Sim to connect Slack.')
-    expect(result.text).not.toContain('sim.example.evil.test')
-    expect(result.text).not.toContain(ESC)
+  it('links service-account setup to the active workspace without exposing tag values', () => {
+    const result = renderChatStructured(
+      '<credential>{"type":"service_account","provider":"Slack","credentialId":"cred-1"}</credential>',
+      {
+        simEndpoint: 'https://sim.example/api',
+        workspaceId: 'workspace / 1',
+      }
+    )
+
+    expect(result.text).toBe(
+      'Connect Slack with a service account in Sim:\nhttps://sim.example/workspace/workspace%20%2F%201/integrations'
+    )
+    expect(result.text).not.toContain('cred-1')
   })
 
   it('sanitizes workspace titles before rendering a plain resource name', () => {