fix(oracle-fusion): preserve int64 identifiers

Author: Bill Leoutsakos

apps/sim/lib/internal/oracle-fusion-financials/client.ts

@@ -15,6 +15,32 @@ const REQUEST_TIMEOUT_MS = 30_000
 const RESPONSE_MAX_BYTES = 5 * 1024 * 1024
 const MAX_RETRIES = 2
 const TRANSIENT_STATUSES = new Set([429, 503, 504])
+const LOSSLESS_DECIMAL_FIELDS = new Set([
+  'InvoiceId',
+  'InvoiceDistributionId',
+  'CheckId',
+  'PaymentId',
+  'PaymentReference',
+  'PaymentNumber',
+  'InvoicePaymentId',
+  'HoldId',
+  'PaymentProcessRequestId',
+  'SourceApplicationIdentifier',
+  'termsId',
+  'setId',
+])
+const DECIMAL_INTEGER_TOKEN = /^\d+$/
+
+interface JsonParseContext {
+  source?: string
+}
+
+type JsonParseWithSource = (
+  text: string,
+  reviver: (this: unknown, key: string, value: unknown, context?: JsonParseContext) => unknown
+) => unknown
+
+const jsonParseWithSource = JSON.parse as JsonParseWithSource
 
 export class OracleFusionFinancialsProviderError extends Error {
   constructor(
@@ -60,6 +86,15 @@ function sanitizeOracleError(body: string, accessToken: string, status: number):
   return safe || `Oracle Fusion Financials request failed with HTTP ${status}`
 }
 
+/** Keeps Oracle int64 identifiers exact while leaving monetary and counter fields numeric. */
+function parseOracleFusionJson(body: string): unknown {
+  return jsonParseWithSource(body, (key, value, context) => {
+    if (!LOSSLESS_DECIMAL_FIELDS.has(key) || typeof value !== 'number') return value
+    const source = context?.source
+    return source && DECIMAL_INTEGER_TOKEN.test(source) ? source : value
+  })
+}
+
 export interface OracleFusionRequest {
   path: string
   query?: Record<string, string | number | boolean | undefined>
@@ -153,7 +188,7 @@ export async function requestOracleFusionJson(
       )
     }
     try {
-      return JSON.parse(body) as unknown
+      return parseOracleFusionJson(body)
     } catch {
       throw new OracleFusionFinancialsProviderError(
         'Oracle Fusion Financials returned a malformed JSON response',

apps/sim/lib/internal/oracle-fusion-financials/oracle-fusion-financials.test.ts

@@ -366,6 +366,20 @@ const BOOLEAN_FIELDS = new Set([
   'ReversedFlag',
   'TrackAsAssetFlag',
 ])
+const DECIMAL_STRING_FIELDS = new Set([
+  'InvoiceId',
+  'InvoiceDistributionId',
+  'CheckId',
+  'PaymentId',
+  'PaymentReference',
+  'PaymentNumber',
+  'InvoicePaymentId',
+  'HoldId',
+  'PaymentProcessRequestId',
+  'SourceApplicationIdentifier',
+  'termsId',
+  'setId',
+])
 const NUMBER_FIELDS = new Set([
   'AmountPaid',
   'AmountPaidInvoiceCurrency',
@@ -374,7 +388,6 @@ const NUMBER_FIELDS = new Set([
   'AppliedAmount',
   'AvailableAmount',
   'BaseAmount',
-  'CheckId',
   'CrossCurrencyRate',
   'cutoffDay',
   'dayOfMonth',
@@ -390,26 +403,18 @@ const NUMBER_FIELDS = new Set([
   'firstDiscountPercent',
   'FirstDiscountAmount',
   'GrossAmount',
-  'HoldId',
   'IncludedTax',
   'InstallmentNumber',
   'InvoiceAmount',
   'InvoiceBaseAmount',
-  'InvoiceDistributionId',
-  'InvoiceId',
   'InvoicePaymentAmount',
-  'InvoicePaymentId',
   'LineAmount',
   'LineHeld',
   'LineNumber',
   'monthsAhead',
   'PaymentAmount',
   'PaymentBaseAmount',
-  'PaymentId',
-  'PaymentNumber',
   'PaymentPriority',
-  'PaymentProcessRequestId',
-  'PaymentReference',
   'PurchaseOrderDistributionLineNumber',
   'PurchaseOrderLineNumber',
   'PurchaseOrderScheduleLineNumber',
@@ -422,9 +427,6 @@ const NUMBER_FIELDS = new Set([
   'secondDiscountPercent',
   'SecondDiscountAmount',
   'sequenceNumber',
-  'setId',
-  'SourceApplicationIdentifier',
-  'termsId',
   'thirdDiscountDayOfMonth',
   'thirdDiscountDays',
   'thirdDiscountMonthsForward',
@@ -548,7 +550,13 @@ function documentedFixture(fields: readonly string[]): Record<string, unknown> {
   return Object.fromEntries(
     fields.map((field) => [
       field,
-      BOOLEAN_FIELDS.has(field) ? true : NUMBER_FIELDS.has(field) ? 1 : 'value',
+      BOOLEAN_FIELDS.has(field)
+        ? true
+        : DECIMAL_STRING_FIELDS.has(field)
+          ? '1'
+          : NUMBER_FIELDS.has(field)
+            ? 1
+            : 'value',
     ])
   )
 }
@@ -771,7 +779,7 @@ describe('Oracle Fusion Financials provider', () => {
   )
 
   it.each(RESOURCE_SCHEMA_CASES)(
-    'accepts documented scalar types and nullable values for the %s projection',
+    'accepts projected scalar types and documented nullable values for the %s projection',
     (_name, schema, fields, nonNullableFields) => {
       expect(schema.parse(documentedFixture(fields))).toMatchObject(documentedFixture(fields))
       const nullableFixture = Object.fromEntries(
@@ -801,6 +809,16 @@ describe('Oracle Fusion Financials provider', () => {
     }
   )
 
+  it('publishes lossless Oracle identity and reference fields as decimal strings', () => {
+    for (const [fields, properties] of RESOURCE_OUTPUT_CASES) {
+      for (const field of fields) {
+        if (DECIMAL_STRING_FIELDS.has(field)) {
+          expect(properties[field], field).toMatchObject({ type: 'string' })
+        }
+      }
+    }
+  })
+
   it.each(RESOURCE_SCHEMA_CASES)(
     'rejects the wrong scalar type for every %s projection field',
     (_name, schema, fields) => {
@@ -989,12 +1007,46 @@ describe('Oracle Fusion Financials provider', () => {
   })
 
   it.each(['PaymentReference', 'PaymentNumber'])(
-    'rejects a fractional %s even though other payment amounts accept decimals',
+    'rejects a non-decimal %s even though other payment amounts accept decimals',
     (field) => {
-      expect(oracleFusionPaymentSchema.safeParse({ [field]: 1.5 }).success).toBe(false)
+      expect(oracleFusionPaymentSchema.safeParse({ [field]: '1.5' }).success).toBe(false)
+      expect(oracleFusionPaymentSchema.safeParse({ [field]: 1 }).success).toBe(false)
     }
   )
 
+  it('preserves Oracle int64 identity tokens exactly as decimal strings', async () => {
+    mockSecureFetch.mockResolvedValueOnce(
+      response(
+        200,
+        `{"items":[{"InvoiceId":9007199254740993,"InvoiceNumber":"INV-1","links":[{"rel":"self","href":"${ORIGIN}${INVOICE_PATH}"}]}],"count":1,"hasMore":false,"limit":50,"offset":0}`
+      )
+    )
+
+    const result = await executeOracleFusionFinancialsOperation(
+      'oracle_fusion_financials_list_payables_invoices',
+      AUTH
+    )
+
+    expect((result.output.items as Array<Record<string, unknown>>)[0]?.InvoiceId).toBe(
+      '9007199254740993'
+    )
+  })
+
+  it('normalizes every projected Oracle identity token before schema validation', async () => {
+    const rawFields = [...DECIMAL_STRING_FIELDS]
+      .map((field) => `"${field}":9007199254740993`)
+      .join(',')
+    mockSecureFetch.mockResolvedValueOnce(response(200, `{${rawFields}}`))
+
+    const result = (await requestOracleFusionJson(AUTH, {
+      path: `${RESOURCE_PATH}/invoices`,
+    })) as Record<string, unknown>
+
+    expect(result).toEqual(
+      Object.fromEntries([...DECIMAL_STRING_FIELDS].map((field) => [field, '9007199254740993']))
+    )
+  })
+
   it('maps an oversized or otherwise unreadable response body to a sanitized 502', async () => {
     mockSecureFetch.mockResolvedValueOnce({
       ...response(200, {}),

apps/sim/lib/internal/oracle-fusion-financials/schema.ts

@@ -249,14 +249,16 @@ const oracleNonNullableText = z.string().optional()
 const oracleNonNullableNumber = z.number().finite().optional()
 const oracleNonNullableInteger = z.number().int().finite().optional()
 const oracleNonNullableBoolean = z.boolean().optional()
+const oracleDecimalString = z.string().regex(/^\d+$/).nullable().optional()
+const oracleNonNullableDecimalString = z.string().regex(/^\d+$/).optional()
 const linkSchema = z
   .object({ rel: z.string().optional(), href: z.string().optional() })
   .passthrough()
 const linksShape = { links: z.array(linkSchema).optional() }
 
 export const oracleFusionInvoiceSchema = z
   .object({
-    InvoiceId: oracleNonNullableInteger,
+    InvoiceId: oracleNonNullableDecimalString,
     InvoiceNumber: oracleNonNullableText,
     Supplier: oracleText,
     SupplierNumber: oracleNonNullableText,
@@ -334,7 +336,7 @@ export const oracleFusionInstallmentSchema = z
 
 export const oracleFusionInvoiceDistributionSchema = z
   .object({
-    InvoiceDistributionId: oracleNonNullableInteger,
+    InvoiceDistributionId: oracleNonNullableDecimalString,
     DistributionLineNumber: oracleNonNullableInteger,
     DistributionLineType: oracleText,
     DistributionAmount: oracleNonNullableNumber,
@@ -397,10 +399,10 @@ export const oracleFusionAvailablePrepaymentSchema = z
 
 export const oracleFusionPaymentSchema = z
   .object({
-    CheckId: oracleNonNullableInteger,
-    PaymentId: oracleInteger,
-    PaymentReference: oracleInteger,
-    PaymentNumber: oracleNonNullableInteger,
+    CheckId: oracleNonNullableDecimalString,
+    PaymentId: oracleDecimalString,
+    PaymentReference: oracleDecimalString,
+    PaymentNumber: oracleNonNullableDecimalString,
     PaymentAmount: oracleNonNullableNumber,
     PaymentCurrency: oracleNonNullableText,
     PaymentDate: oracleNonNullableText,
@@ -422,9 +424,9 @@ export const oracleFusionPaymentSchema = z
 
 export const oracleFusionPaymentRelatedInvoiceSchema = z
   .object({
-    InvoicePaymentId: oracleNonNullableInteger,
-    CheckId: oracleNonNullableInteger,
-    InvoiceId: oracleNonNullableInteger,
+    InvoicePaymentId: oracleNonNullableDecimalString,
+    CheckId: oracleNonNullableDecimalString,
+    InvoiceId: oracleNonNullableDecimalString,
     InvoiceBusinessUnit: oracleText,
     InvoiceNumber: oracleNonNullableText,
     InstallmentNumber: oracleNonNullableInteger,
@@ -447,7 +449,7 @@ export const oracleFusionPaymentRelatedInvoiceSchema = z
 
 export const oracleFusionInvoiceHoldSchema = z
   .object({
-    HoldId: oracleNonNullableInteger,
+    HoldId: oracleNonNullableDecimalString,
     InvoiceNumber: oracleText,
     BusinessUnit: oracleText,
     Supplier: oracleText,
@@ -475,9 +477,9 @@ export const oracleFusionInvoiceHoldSchema = z
 
 export const oracleFusionPaymentProcessRequestSchema = z
   .object({
-    PaymentProcessRequestId: oracleNonNullableInteger,
+    PaymentProcessRequestId: oracleNonNullableDecimalString,
     PaymentProcessRequestName: oracleNonNullableText,
-    SourceApplicationIdentifier: oracleNonNullableInteger,
+    SourceApplicationIdentifier: oracleNonNullableDecimalString,
     PaymentProcessRequestStatusCode: oracleNonNullableText,
     PaymentProcessRequestStatusMeaning: oracleText,
     ...linksShape,
@@ -486,15 +488,15 @@ export const oracleFusionPaymentProcessRequestSchema = z
 
 export const oracleFusionPaymentTermSchema = z
   .object({
-    termsId: oracleNonNullableInteger,
+    termsId: oracleNonNullableDecimalString,
     name: oracleNonNullableText,
     description: oracleText,
     enabledFlag: oracleNonNullableBoolean,
     fromDate: oracleNonNullableText,
     toDate: oracleText,
     cutoffDay: oracleInteger,
     rank: oracleInteger,
-    setId: oracleNonNullableInteger,
+    setId: oracleNonNullableDecimalString,
     creationDate: oracleNonNullableText,
     lastUpdateDate: oracleNonNullableText,
     ...linksShape,
@@ -503,7 +505,7 @@ export const oracleFusionPaymentTermSchema = z
 
 export const oracleFusionPaymentTermLineSchema = z
   .object({
-    termsId: oracleNonNullableInteger,
+    termsId: oracleNonNullableDecimalString,
     sequenceNumber: oracleNonNullableInteger,
     amountDue: oracleNumber,
     calendar: oracleText,