Skip to content

Commit 5610ade

Browse files
committed
fix(docs): abort before writing on a parse failure, unhang three descriptions
The guard's own TSDoc said to fail rather than guess, because the fallback strips every hidden param from a page. The caller did the opposite: it caught, recorded, and continued with an empty id set, and the non-zero exit came after every page was already written. A developer who reran, saw red, and missed the scrollback could commit a stripped page. Parse failures are now detected in a dry pass before anything is emitted. The zero-id guard also only fired when the array held a literal '{', so a subBlocks built by a helper call was silently empty, while a subBlocks whose literals only spread ({ ...sb, required: true }) hard-failed the build. It now fires on the destructive case alone -- reporting an unreadable array while leaving legitimate opaque spreads, which 23 blocks rely on, untouched. Three descriptions referenced things the reader can no longer see: Dataverse mandated base64 after its base64 row was removed, Vanta's mimeType described itself as useful only on that removed path, and five Drive actions told the reader to fetch a next page with no input left to accept the token.
1 parent feaa609 commit 5610ade

15 files changed

Lines changed: 325 additions & 103 deletions

File tree

apps/docs/content/docs/en/integrations/google_drive.mdx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ List files and folders in Google Drive with complete metadata
104104
|`isAppAuthorized` | boolean | Whether created by requesting app |
105105
|`contentRestrictions` | json | Content restrictions |
106106
|`linkShareMetadata` | json | Link share metadata |
107-
| `nextPageToken` | string | Token for fetching the next page of results |
107+
| `nextPageToken` | string | Google Drive pagination cursor returned when more files remain beyond this response; empty when this is the last page |
108108

109109
### Get Google Drive File
110110

@@ -516,7 +516,7 @@ Search for files in Google Drive using advanced query syntax (e.g., fullText con
516516
|`driveId` | string | Shared drive ID |
517517
|`capabilities` | json | User capabilities on file |
518518
|`version` | string | Version number |
519-
| `nextPageToken` | string | Token for fetching the next page of results |
519+
| `nextPageToken` | string | Google Drive pagination cursor returned when more files remain beyond this response; empty when this is the last page |
520520

521521
### Update Google Drive File
522522

@@ -689,7 +689,7 @@ List all permissions (who has access) for a file in Google Drive
689689
|`allowFileDiscovery` | boolean | Whether file is discoverable by grantee |
690690
|`pendingOwner` | boolean | Whether ownership transfer is pending |
691691
|`permissionDetails` | json | Details about inherited permissions |
692-
| `nextPageToken` | string | Token for fetching the next page of permissions |
692+
| `nextPageToken` | string | Google Drive pagination cursor returned when more permissions remain beyond this response; empty when this is the last page |
693693

694694
### Export Google Drive File
695695

@@ -737,7 +737,7 @@ List the revision history of a file in Google Drive
737737
|`md5Checksum` | string | MD5 checksum for binary revisions |
738738
|`size` | string | Size of the revision in bytes |
739739
|`exportLinks` | json | Export format links for the revision |
740-
| `nextPageToken` | string | Token for fetching the next page of revisions |
740+
| `nextPageToken` | string | Google Drive pagination cursor returned when more revisions remain beyond this response; empty when this is the last page |
741741

742742
### Get Google Drive Revision
743743

@@ -796,7 +796,7 @@ List comments on a file in Google Drive
796796
|`anchor` | string | Region of the document the comment refers to |
797797
|`quotedFileContent` | json | The file content the comment quotes |
798798
|`replies` | json | Threaded replies to the comment |
799-
| `nextPageToken` | string | Token for fetching the next page of comments |
799+
| `nextPageToken` | string | Google Drive pagination cursor returned when more comments remain beyond this response; empty when this is the last page |
800800

801801
### Create Google Drive Comment
802802

apps/docs/content/docs/en/integrations/microsoft_dataverse.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,7 @@ Update an existing record in a Microsoft Dataverse table. Only send the columns
387387

388388
### Upload File to Microsoft Dataverse
389389

390-
Upload a file to a file or image column on a Dataverse record. Supports single-request upload for files up to 128 MB. The file content must be provided as a base64-encoded string.
390+
Upload a file to a file or image column on a Dataverse record. Supports single-request upload for files up to 128 MB. Provide the file through the File input; its bytes are read from storage and sent to Dataverse directly.
391391

392392
#### Input
393393

apps/docs/content/docs/en/integrations/vanta.mdx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,7 +331,7 @@ Upload an evidence file to a Vanta document. Requires credentials with the vanta
331331
| `documentId` | string | Yes | Unique ID of the document to attach the file to |
332332
| `file` | file | No | The evidence file to upload |
333333
| `fileName` | string | No | Optional file name override |
334-
| `mimeType` | string | No | MIME type of the file \(e.g., application/pdf\); used when uploading base64 content, since uploaded files already carry their own type |
334+
| `mimeType` | string | No | MIME type of the file \(e.g., application/pdf\); used only as a fallback when the uploaded file does not carry a content type of its own |
335335
| `description` | string | No | Description of the uploaded evidence \(e.g., "Q3 access review evidence"\) |
336336
| `effectiveAtDate` | string | No | ISO 8601 date indicating when the document is effective from |
337337

apps/sim/tools/generated/tool-metadata.ts

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

apps/sim/tools/generated/tool-outputs.ts

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

apps/sim/tools/google_drive/list.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,7 +198,8 @@ export const listTool: ToolConfig<GoogleDriveToolParams, GoogleDriveListResponse
198198
},
199199
nextPageToken: {
200200
type: 'string',
201-
description: 'Token for fetching the next page of results',
201+
description:
202+
'Google Drive pagination cursor returned when more files remain beyond this response; empty when this is the last page',
202203
},
203204
},
204205
}

apps/sim/tools/google_drive/list_comments.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,8 @@ export const listCommentsTool: ToolConfig<
134134
},
135135
nextPageToken: {
136136
type: 'string',
137-
description: 'Token for fetching the next page of comments',
137+
description:
138+
'Google Drive pagination cursor returned when more comments remain beyond this response; empty when this is the last page',
138139
},
139140
},
140141
}

apps/sim/tools/google_drive/list_permissions.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,8 @@ export const listPermissionsTool: ToolConfig<
134134
},
135135
nextPageToken: {
136136
type: 'string',
137-
description: 'Token for fetching the next page of permissions',
137+
description:
138+
'Google Drive pagination cursor returned when more permissions remain beyond this response; empty when this is the last page',
138139
},
139140
},
140141
}

apps/sim/tools/google_drive/list_revisions.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,8 @@ export const listRevisionsTool: ToolConfig<
120120
},
121121
nextPageToken: {
122122
type: 'string',
123-
description: 'Token for fetching the next page of revisions',
123+
description:
124+
'Google Drive pagination cursor returned when more revisions remain beyond this response; empty when this is the last page',
124125
},
125126
},
126127
}

apps/sim/tools/google_drive/search.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,8 @@ export const searchTool: ToolConfig<GoogleDriveSearchParams, GoogleDriveSearchRe
144144
},
145145
nextPageToken: {
146146
type: 'string',
147-
description: 'Token for fetching the next page of results',
147+
description:
148+
'Google Drive pagination cursor returned when more files remain beyond this response; empty when this is the last page',
148149
},
149150
},
150151
}

0 commit comments

Comments
 (0)