fix(enrichment): separate save and row readiness

Author: TheodoreSpeaks

apps/sim/enrichments/readiness.test.ts

@@ -18,7 +18,7 @@ describe('getEnrichmentReadiness', () => {
     ])
   })
 
-  it('accepts either a company domain or LinkedIn URL', () => {
+  it('accepts either a name with company domain or a LinkedIn URL', () => {
     expect(
       getEnrichmentReadiness(workEmailEnrichment, {
         fullName: 'John Doe',
@@ -27,12 +27,20 @@ describe('getEnrichmentReadiness', () => {
     ).toBe(true)
     expect(
       getEnrichmentReadiness(workEmailEnrichment, {
-        fullName: 'John Doe',
         linkedinUrl: 'https://linkedin.com/in/johndoe',
       }).ready
     ).toBe(true)
   })
 
+  it('does not treat a save-required mapping as a required value for every row', () => {
+    const readiness = getEnrichmentReadiness(workEmailEnrichment, {
+      fullName: '',
+      linkedinUrl: 'https://linkedin.com/in/johndoe',
+    })
+
+    expect(readiness).toEqual({ ready: true, missingInputs: [] })
+  })
+
   it('reports missing required inputs before provider-specific inputs', () => {
     const readiness = getEnrichmentReadiness(workEmailEnrichment, {
       companyDomain: 'acme.com',

apps/sim/enrichments/readiness.ts

@@ -18,14 +18,14 @@ export interface EnrichmentRowReadiness extends EnrichmentReadiness {
   inputColumnById: ReadonlyMap<string, string>
 }
 
-/**
- * Checks whether an enrichment has its required inputs and at least one
- * provider can build a valid request from the available values.
- */
+/** Checks whether at least one provider can build a valid request. */
 export function getEnrichmentReadiness(
   enrichment: EnrichmentConfig,
   inputs: Record<string, unknown>
 ): EnrichmentReadiness {
+  const ready = enrichment.providers.some((provider) => provider.buildParams(inputs) !== null)
+  if (ready) return { ready: true, missingInputs: [] }
+
   const isEmpty = (value: unknown) =>
     value === undefined || value === null || (typeof value === 'string' && value.trim() === '')
   const missingRequired = enrichment.inputs.filter(
@@ -35,9 +35,6 @@ export function getEnrichmentReadiness(
     return { ready: false, missingInputs: missingRequired }
   }
 
-  const ready = enrichment.providers.some((provider) => provider.buildParams(inputs) !== null)
-  if (ready) return { ready: true, missingInputs: [] }
-
   const providerSpecificInputs = enrichment.inputs.filter((input) => !input.required)
   return {
     ready: false,

apps/sim/enrichments/types.ts

@@ -9,6 +9,7 @@ export interface EnrichmentInputField {
   /** Human label shown in the config panel. */
   name: string
   type: 'string' | 'number' | 'boolean'
+  /** Whether a column mapping is required before the enrichment can be saved. */
   required?: boolean
   description?: string
 }