docs(copilot): state that a named run may resolve to nothing

Both reviewers read an id on a preflight failure as a defect. It is the
one place this contract is deliberately coarse, so say so where each of
them was looking rather than leave it to be rediscovered.

`attempted` already means "zero or one executions exist under this id" —
the id is a correlation key, not a promise that a row exists. A caller
resolves it, finds nothing, and retries, which is the right outcome at the
cost of one lookup.

Buying that lookup back means an executor-side dispatch marker: a callback
on every block of every execution in the product, which this branch just
reverted for that reason. It would also gain nothing, since all four
preflight throws are invariant violations — no workspace id, no billing
attribution, no principal, attribution mismatch — and a retry fails
identically.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: icecrasher321

apps/sim/lib/copilot/tool-executor/types.ts

@@ -56,7 +56,14 @@ export interface ToolExecutionContext {
 export const TOOL_EFFECT_PHASE = {
   /** Rejected before anything could happen. Correcting the call and retrying is safe. */
   notAttempted: 'not_attempted',
-  /** Dispatched; zero or one effects may exist. Resolve by id before retrying. */
+  /**
+   * Dispatched; zero or one effects may exist. Resolve by id before retrying.
+   *
+   * Zero is a legitimate outcome here, not a defect: the id is a correlation key, not a
+   * promise that a row exists. Narrowing this to "a run definitely exists" would take
+   * per-block instrumentation across every execution in the product to spare one caller a
+   * lookup that answers the question definitively either way.
+   */
   attempted: 'attempted',
   /** The effect ran to completion, whatever its outcome. Never retry blind. */
   performed: 'performed',

apps/sim/lib/workflows/application/run-workflow-from-copilot.test.ts

@@ -334,6 +334,17 @@ describe('Copilot workflow run application commands', () => {
       expect(readAttemptedExecutionId(await failWith())).toBe('child-execution-1')
     })
 
+    /**
+     * Deliberate, and the one place this contract is deliberately coarse: `executeWorkflow`
+     * validates its own arguments before creating anything, and those failures still name
+     * the run. `attempted` means "zero or one executions exist under this id, resolve it",
+     * so the caller resolves, finds nothing, and retries — correct, at the cost of a lookup.
+     *
+     * Paying to avoid that lookup means an executor-side dispatch marker, which is a
+     * callback on every block of every execution in the product. It would also buy nothing:
+     * all four preflight throws are invariant violations — no workspace id, no billing
+     * attribution, no principal, attribution mismatch — so a retry fails identically.
+     */
     it('names the run for a failure inside the executor call, whatever its cause', async () => {
       mocks.executeWorkflow.mockRejectedValueOnce(
         new Error('Billing attribution is required for workspace execution')