fix(files): skip malformed export assets

Author: waleedlatif1

apps/sim/app/api/files/export/[id]/route.test.ts

@@ -51,7 +51,7 @@ function request() {
   return createMockRequest('GET', undefined, {}, `http://localhost:3000/api/files/export/${DOC_ID}`)
 }
 
-function assetRecord(id: string, size: number) {
+function assetRecord(id: string, size: number | null) {
   return {
     id,
     key: `workspace/ws-1/${id}`,
@@ -161,6 +161,21 @@ describe('markdown export bundling', () => {
     expect(zip.file('assets/bad.png')).toBeNull()
   })
 
+  it('drops an asset with missing canonical size metadata', async () => {
+    embeds('good', 'missing-size')
+    assetsResolveTo((id) => assetRecord(id, id === 'missing-size' ? null : 1 * MB))
+
+    const response = await GET(request(), context)
+
+    expect(response.status).toBe(200)
+    const zip = await JSZip.loadAsync(Buffer.from(await response.arrayBuffer()))
+    expect(zip.file('assets/good.png')).not.toBeNull()
+    expect(zip.file('assets/missing-size.png')).toBeNull()
+    expect(
+      mockDownloadFile.mock.calls.some(([options]) => options.key.endsWith('missing-size'))
+    ).toBe(false)
+  })
+
   /**
    * The two id representations have to stay distinct: metadata resolves by the stored id, while the
    * rewrite finds the embed by the spelling the document used. Collapsing them either drops the

apps/sim/app/api/files/export/[id]/route.ts

@@ -165,7 +165,7 @@ export const GET = withRouteHandler(
           const imgRecord = await getFileMetadataById(storedFileId(imageId))
           if (!imgRecord) return null
           if (!(await verifyFileAccess(imgRecord.key, userId))) return null
-          return { imageId, record: imgRecord }
+          return { imageId, record: imgRecord, size: getWorkspaceFileSize(imgRecord) }
         } catch (error) {
           logger.warn('Failed to resolve asset for export', {
             imageId,
@@ -178,9 +178,7 @@ export const GET = withRouteHandler(
 
     // The body counts against the same budget as its assets — the zip holds both, so a
     // limit that measured only the attachments would not describe the archive produced.
-    const bundleBytes =
-      mdBuffer.length +
-      assetTargets.reduce((sum, target) => sum + getWorkspaceFileSize(target.record), 0)
+    const bundleBytes = mdBuffer.length + assetTargets.reduce((sum, target) => sum + target.size, 0)
     if (bundleBytes > MAX_EXPORT_TOTAL_BYTES) {
       return NextResponse.json(
         {