fix(byok): hide stale inherited status badges

Author: Bill Leoutsakos

apps/sim/app/workspace/[workspaceId]/settings/components/byok/byok.test.tsx

@@ -162,7 +162,7 @@ vi.mock('@/hooks/queries/byok-keys', () => ({
     return mocks.organizationResult.current
   },
   useInheritedBYOKStatus: () => ({
-    data: mocks.inheritedStatusError.current ? undefined : { inheritedProviderIds: ['anthropic'] },
+    data: { inheritedProviderIds: ['anthropic'] },
     isError: mocks.inheritedStatusError.current,
   }),
   useUpsertBYOKKey: mocks.mutation,
@@ -258,6 +258,7 @@ describe('BYOK scope access', () => {
     expect(container.textContent).toContain(
       'Inherited key status unavailable. Refresh to try again.'
     )
+    expect(container.textContent).not.toContain('Inherited from organization')
     expect(container.querySelector('[aria-label="BYOK manager"]')).toHaveAttribute(
       'data-capabilities',
       'true:true:true'

apps/sim/app/workspace/[workspaceId]/settings/components/byok/byok.tsx

@@ -435,7 +435,7 @@ export function BYOK() {
   }, [activeKeys])
 
   const providers = useMemo(() => {
-    if (isOrganizationScope) return PROVIDERS
+    if (isOrganizationScope || inheritedStatus.isError) return PROVIDERS
 
     const inheritedProviderIds = new Set(inheritedStatus.data?.inheritedProviderIds ?? [])
     if (inheritedProviderIds.size === 0) return PROVIDERS
@@ -445,7 +445,7 @@ export function BYOK() {
         ? { ...provider, badge: <ChipTag variant='gray'>Inherited from organization</ChipTag> }
         : provider
     )
-  }, [inheritedStatus.data?.inheritedProviderIds, isOrganizationScope])
+  }, [inheritedStatus.data?.inheritedProviderIds, inheritedStatus.isError, isOrganizationScope])
 
   const description = isOrganizationScope
     ? organizationKeys.data?.entitled === false