fix(ui): preserve resource view collapse state

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-tabs/resource-tab-controls.ts

@@ -10,7 +10,7 @@ export const RESOURCE_TAB_ICON_CLASS = 'size-[16px] text-[var(--text-icon)]'
 /** Shared geometry for the resource header and controls positioned over it. */
 export const RESOURCE_HEADER_CLASSES = {
   layout:
-    '[--resource-header-controls-height:40px] [--resource-header-end-inset:16px] [--resource-header-fixed-reserve:54px] [--resource-header-toggle-size:30px]',
+    '[--resource-header-controls-height:40px] [--resource-header-end-inset:16px] [--resource-header-fixed-reserve:64px] [--resource-header-toggle-hit-size:40px] [--resource-header-toggle-size:30px]',
   /**
    * Drives the tab strip from this header's own tokens rather than restating the
    * strip's defaults, so the height the overlaid controls below are positioned
@@ -38,11 +38,10 @@ export const RESOURCE_HEADER_CLASSES = {
   overlay: 'absolute top-0 flex h-[var(--resource-header-controls-height)] items-center',
   endPosition: 'right-[var(--resource-header-end-inset)]',
   /**
-   * Sits a control 1px clear of the overlaid 30px collapse toggle — the same
-   * chip-to-chip gap the sidebar header cluster uses (`gap-[1px]`), so the
-   * credits chip and the toggle read as one cluster across both surfaces.
+   * Clears the collapse toggle's 40px hit target so adjacent controls never
+   * compete for the same pointer area. The visible toggle remains 30px.
    */
   adjacentEndPosition:
-    'right-[calc(var(--resource-header-end-inset)_+_var(--resource-header-toggle-size)_+_1px)]',
+    'right-[calc(var(--resource-header-end-inset)_+_var(--resource-header-toggle-hit-size)_+_1px)]',
   emptyAddOffset: '-translate-x-1.5',
 } as const

apps/sim/app/workspace/[workspaceId]/home/home.tsx

@@ -36,6 +36,7 @@ import { captureEvent } from '@/lib/posthog/client'
 import { persistImportedWorkflow } from '@/lib/workflows/operations/import-export'
 import { RESOURCE_HEADER_CLASSES } from '@/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-tabs/resource-tab-controls'
 import { resolveWorkspaceResourceRef } from '@/app/workspace/[workspaceId]/home/resolve-resource-ref'
+import { resolveResourceEventPresentation } from '@/app/workspace/[workspaceId]/home/resource-view-policy'
 import { resourceParam, resourceUrlKeys } from '@/app/workspace/[workspaceId]/home/search-params'
 import { useFolders } from '@/hooks/queries/folders'
 import { useMarkMothershipChatRead } from '@/hooks/queries/mothership-chats'
@@ -202,23 +203,32 @@ export function Home({ chatId, userName, userId }: HomeProps) {
 
   const { mutate: markRead } = useMarkMothershipChatRead(workspaceId)
 
-  const [isResourceCollapsed, setIsResourceCollapsed] = useState(true)
+  const [isResourceCollapsed, setIsResourceCollapsedState] = useState(true)
   const [skipResourceTransition, setSkipResourceTransition] = useState(false)
   const [resourceActivityIds, setResourceActivityIds] = useState<Set<string>>(new Set())
   const isResourceCollapsedRef = useRef(isResourceCollapsed)
-  isResourceCollapsedRef.current = isResourceCollapsed
-  const userOwnsResourceViewRef = useRef(false)
+  const setResourceCollapsed = useCallback((collapsed: boolean) => {
+    isResourceCollapsedRef.current = collapsed
+    setIsResourceCollapsedState(collapsed)
+  }, [])
+  const resourceCollapseOwnedByUserRef = useRef(false)
+  const resourceSelectionOwnedByUserRef = useRef(false)
   const activeResourceParamRef = useRef(activeResourceParam)
   activeResourceParamRef.current = activeResourceParam
 
   function handleResourceEvent(resourceId: string, options?: ResourceEventOptions) {
-    // Agent work surfaces the resource and switches to it as it is created or
-    // edited; only the browser session stays in the background behind an
-    // existing selection (see shouldActivateResourceEvent).
-    if (isResourceCollapsedRef.current) setIsResourceCollapsed(false)
-
     const activeResourceId = activeResourceParamRef.current
-    if (!shouldActivateResourceEvent(activeResourceId, resourceId, options)) {
+    const presentation = resolveResourceEventPresentation({
+      activeResourceId,
+      activationRequested: shouldActivateResourceEvent(activeResourceId, resourceId, options),
+      panelCollapseOwnedByUser: resourceCollapseOwnedByUserRef.current,
+      panelCollapsed: isResourceCollapsedRef.current,
+      resourceId,
+      selectionOwnedByUser: resourceSelectionOwnedByUserRef.current,
+    })
+
+    if (presentation.revealPanel) setResourceCollapsed(false)
+    if (presentation.markActivity) {
       setResourceActivityIds((current) => new Set(current).add(resourceId))
       return
     }
@@ -228,7 +238,7 @@ export function Home({ chatId, userName, userId }: HomeProps) {
       next.delete(resourceId)
       return next
     })
-    if (activeResourceId !== resourceId) {
+    if (presentation.activateResource && activeResourceId !== resourceId) {
       activeResourceParamRef.current = resourceId
       setActiveResourceUrl(resourceId)
     }
@@ -282,10 +292,11 @@ export function Home({ chatId, userName, userId }: HomeProps) {
   const resourceAttentionChatIdRef = useRef(resolvedChatId)
 
   const collapseResource = useCallback(() => {
-    userOwnsResourceViewRef.current = true
+    resourceCollapseOwnedByUserRef.current = true
+    resourceSelectionOwnedByUserRef.current = true
     clearWidth()
-    setIsResourceCollapsed(true)
-  }, [clearWidth])
+    setResourceCollapsed(true)
+  }, [clearWidth, setResourceCollapsed])
 
   const clearResourceActivity = useCallback((resourceId: string) => {
     setResourceActivityIds((current) => {
@@ -297,15 +308,16 @@ export function Home({ chatId, userName, userId }: HomeProps) {
   }, [])
 
   const expandResource = () => {
-    userOwnsResourceViewRef.current = true
+    resourceCollapseOwnedByUserRef.current = false
+    resourceSelectionOwnedByUserRef.current = true
     const activeResourceId = activeResourceParamRef.current
     if (activeResourceId) clearResourceActivity(activeResourceId)
-    setIsResourceCollapsed(false)
+    setResourceCollapsed(false)
   }
 
   const selectResourceFromUser = useCallback(
     (resourceId: string) => {
-      userOwnsResourceViewRef.current = true
+      resourceSelectionOwnedByUserRef.current = true
       clearResourceActivity(resourceId)
       if (effectiveActiveResourceIdRef.current === resourceId) return
       effectiveActiveResourceIdRef.current = resourceId
@@ -317,24 +329,30 @@ export function Home({ chatId, userName, userId }: HomeProps) {
 
   const addResourceFromUser = useCallback(
     (resource: MothershipResource) => {
-      userOwnsResourceViewRef.current = true
+      resourceCollapseOwnedByUserRef.current = false
+      resourceSelectionOwnedByUserRef.current = true
       addResource(resource)
       selectResourceFromUser(resource.id)
-      setIsResourceCollapsed(false)
+      setResourceCollapsed(false)
     },
-    [addResource, selectResourceFromUser]
+    [addResource, selectResourceFromUser, setResourceCollapsed]
   )
 
   const handleResourceResizePointerDown = useCallback(
     (event: PointerEvent<HTMLDivElement>) => {
-      userOwnsResourceViewRef.current = true
+      resourceSelectionOwnedByUserRef.current = true
       handleResizePointerDown(event)
     },
     [handleResizePointerDown]
   )
 
   const handleResourceInteraction = useCallback(() => {
-    userOwnsResourceViewRef.current = true
+    resourceSelectionOwnedByUserRef.current = true
+  }, [])
+
+  const prepareResourceViewForAgentTurn = useCallback(() => {
+    resourceSelectionOwnedByUserRef.current = false
+    setResourceActivityIds(new Set())
   }, [])
 
   useEffect(() => {
@@ -345,13 +363,14 @@ export function Home({ chatId, userName, userId }: HomeProps) {
       markRead(resolvedChatId)
     } else {
       clearWidth()
-      setIsResourceCollapsed(true)
+      setResourceCollapsed(true)
     }
     if (!resolvedChatId || (previousChatId && previousChatId !== resolvedChatId)) {
-      userOwnsResourceViewRef.current = false
+      resourceCollapseOwnedByUserRef.current = false
+      resourceSelectionOwnedByUserRef.current = false
       setResourceActivityIds(new Set())
     }
-  }, [resolvedChatId, markRead, clearWidth])
+  }, [resolvedChatId, markRead, clearWidth, setResourceCollapsed])
 
   useEffect(() => {
     if (wasSendingRef.current && !isSending && resolvedChatId) {
@@ -363,22 +382,22 @@ export function Home({ chatId, userName, userId }: HomeProps) {
   useEffect(() => {
     if (
       !(resources.length > 0 && isResourceCollapsedRef.current) ||
-      userOwnsResourceViewRef.current
+      resourceCollapseOwnedByUserRef.current
     ) {
       return
     }
-    setIsResourceCollapsed(false)
+    setResourceCollapsed(false)
     setSkipResourceTransition(true)
     const id = requestAnimationFrame(() => setSkipResourceTransition(false))
     return () => cancelAnimationFrame(id)
-  }, [resources])
+  }, [resources, setResourceCollapsed])
 
   useEffect(() => {
     if (resources.length === 0 && !isResourceCollapsedRef.current) {
       clearWidth()
-      setIsResourceCollapsed(true)
+      setResourceCollapsed(true)
     }
-  }, [resources, clearWidth])
+  }, [resources, clearWidth, setResourceCollapsed])
 
   useEffect(() => {
     const resourceIds = new Set(resources.map((resource) => resource.id))
@@ -413,11 +432,10 @@ export function Home({ chatId, userName, userId }: HomeProps) {
         setIsInputEntering(true)
       }
 
-      userOwnsResourceViewRef.current = false
-      setResourceActivityIds(new Set())
+      prepareResourceViewForAgentTurn()
       sendMessage(trimmed || 'Analyze the attached file(s).', fileAttachments, contexts)
     },
-    [workspaceId, chatId, sendMessage]
+    [workspaceId, chatId, prepareResourceViewForAgentTurn, sendMessage]
   )
 
   /**
@@ -431,13 +449,14 @@ export function Home({ chatId, userName, userId }: HomeProps) {
       const detail = (e as CustomEvent<MothershipSendMessageDetail>).detail
       if (!detail?.message) return
       e.preventDefault()
+      prepareResourceViewForAgentTurn()
       sendMessage(detail.message, detail.fileAttachments, detail.contexts, {
         ...(detail.resumeUserMessageId ? { resumeUserMessageId: detail.resumeUserMessageId } : {}),
       })
     }
     window.addEventListener(MOTHERSHIP_SEND_MESSAGE_EVENT, handler)
     return () => window.removeEventListener(MOTHERSHIP_SEND_MESSAGE_EVENT, handler)
-  }, [sendMessage])
+  }, [prepareResourceViewForAgentTurn, sendMessage])
 
   /**
    * Consumes a one-shot handoff left by another surface and applies it to this
@@ -462,6 +481,7 @@ export function Home({ chatId, userName, userId }: HomeProps) {
     const handoff = MothershipHandoffStorage.consume(workspaceId)
     if (!handoff) return
     if (handoff.message) {
+      prepareResourceViewForAgentTurn()
       sendMessage(handoff.message, handoff.fileAttachments, handoff.contexts, {
         ...(handoff.resumeUserMessageId
           ? { resumeUserMessageId: handoff.resumeUserMessageId }
@@ -477,7 +497,7 @@ export function Home({ chatId, userName, userId }: HomeProps) {
     // keep it one-shot — and harmless either way, since `consume` clears the entry
     // atomically and any re-run would find nothing.
     // eslint-disable-next-line react-hooks/exhaustive-deps -- see above
-  }, [chatId, workspaceId, sendMessage])
+  }, [chatId, workspaceId, prepareResourceViewForAgentTurn, sendMessage])
 
   function resolveResourceFromContext(
     context: ChatContext
@@ -583,6 +603,12 @@ export function Home({ chatId, userName, userId }: HomeProps) {
   const hasMessages = messages.length > 0
   const showChatSkeleton = Boolean(chatId) && !hasMessages && isChatHistoryPending
   const draftScopeKey = `${workspaceId}:${chatId ?? 'new'}`
+  const resourceActivityCount = resourceActivityIds.size
+  const resourceToggleLabel = isResourceCollapsed
+    ? resourceActivityCount > 0
+      ? `Expand resource view, ${resourceActivityCount} resource${resourceActivityCount === 1 ? '' : 's'} updated`
+      : 'Expand resource view'
+    : 'Collapse resource view'
 
   // The empty state is the chat pane's content, not a layout of its own. It
   // used to return early, which meant the resource panel and its toggle did
@@ -720,13 +746,16 @@ export function Home({ chatId, userName, userId }: HomeProps) {
           size={null}
           type='button'
           onClick={isResourceCollapsed ? expandResource : collapseResource}
-          className='size-[var(--resource-header-toggle-size)] rounded-[8px] hover-hover:bg-[var(--surface-active)]'
-          aria-label={isResourceCollapsed ? 'Expand resource view' : 'Collapse resource view'}
+          className="after:-translate-x-1/2 after:-translate-y-1/2 relative size-[var(--resource-header-toggle-size)] rounded-[8px] after:absolute after:top-1/2 after:left-1/2 after:size-[var(--resource-header-toggle-hit-size)] after:content-[''] hover-hover:bg-[var(--surface-active)]"
+          aria-label={resourceToggleLabel}
         >
           <span className='relative'>
             <PanelLeft className='-scale-x-100 size-[16px] text-[var(--text-icon)]' />
             {isResourceCollapsed && resourceActivityIds.size > 0 && (
-              <span className='-top-0.5 -right-0.5 absolute size-1.5 rounded-full bg-[var(--brand-primary)]' />
+              <span
+                aria-hidden='true'
+                className='-top-0.5 -right-0.5 absolute size-1.5 rounded-full bg-[var(--brand-primary)]'
+              />
             )}
           </span>
         </Button>

apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.test.ts

@@ -61,11 +61,11 @@ describe('selectDeletedWorkflowResources', () => {
 })
 
 describe('shouldActivateResourceEvent', () => {
-  it('surfaces browser work even when another resource is selected', () => {
+  it('requests activation for browser work', () => {
     expect(shouldActivateResourceEvent('file-1', 'browser-session')).toBe(true)
   })
 
-  it('surfaces every other resource the agent touches', () => {
+  it('requests activation for every other resource the agent touches', () => {
     expect(shouldActivateResourceEvent('file-1', 'workflow-1')).toBe(true)
     expect(shouldActivateResourceEvent('browser-session', 'terminal-session')).toBe(true)
     expect(shouldActivateResourceEvent(null, 'browser-session')).toBe(true)

apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.ts

@@ -1215,11 +1215,9 @@ export interface ResourceEventOptions {
 export type ResourceEventHandler = (resourceId: string, options?: ResourceEventOptions) => void
 
 /**
- * Whether a streamed resource event should activate its tab. The panel always
- * follows the agent: whatever it is creating, editing, or driving becomes the
- * visible resource, browser sessions included. The parameters are retained so
- * callers stay explicit about the resource in play, and so a future opt-out
- * (an event that deliberately declines focus) has a place to live.
+ * Whether a streamed resource event requests activation of its tab. The view
+ * may still preserve an explicit user collapse or selection and surface the
+ * event through an activity marker instead.
  */
 export function shouldActivateResourceEvent(
   _activeResourceId: string | null,