fix(db): fail closed on missing file sizes

Author: waleedlatif1

apps/sim/background/cleanup-soft-deletes.test.ts

@@ -121,7 +121,7 @@ describe('cleanup soft deletes', () => {
           key: 'workspace/ws-1/file-failed',
           workspaceId: 'ws-1',
           context: 'workspace',
-          size: 11,
+          sizeBytes: 11,
         },
       ])
     mockDeleteFiles.mockResolvedValueOnce({
@@ -148,14 +148,14 @@ describe('cleanup soft deletes', () => {
           key: 'workspace/ws-1/file-deleted',
           workspaceId: 'ws-1',
           context: 'workspace',
-          size: 7,
+          sizeBytes: 7,
         },
         {
           id: 'file-restored',
           key: 'workspace/ws-1/file-restored',
           workspaceId: 'ws-1',
           context: 'workspace',
-          size: 13,
+          sizeBytes: 13,
         },
       ])
     mockDeleteFiles.mockResolvedValueOnce({ deleted: 2, failed: [] })
@@ -184,7 +184,7 @@ describe('cleanup soft deletes', () => {
           key: 'mothership/chat-file',
           workspaceId: 'ws-1',
           context: 'mothership',
-          size: 17,
+          sizeBytes: 17,
         },
       ])
     mockDeleteFiles.mockResolvedValueOnce({ deleted: 1, failed: [] })
@@ -198,6 +198,26 @@ describe('cleanup soft deletes', () => {
     expect(mockDecrementStorageUsageForBillingContextInTx).not.toHaveBeenCalled()
   })
 
+  it('fails before deleting storage when canonical size metadata is missing', async () => {
+    mockSelectRowsByIdChunks
+      .mockResolvedValueOnce([])
+      .mockResolvedValueOnce([])
+      .mockResolvedValueOnce([
+        {
+          id: 'file-missing-size',
+          key: 'workspace/ws-1/file-missing-size',
+          workspaceId: 'ws-1',
+          context: 'workspace',
+          sizeBytes: null,
+        },
+      ])
+
+    await expect(runCleanupSoftDeletes(basePayload)).rejects.toThrow(
+      'Workspace file is missing canonical size_bytes metadata'
+    )
+    expect(mockDeleteFiles).not.toHaveBeenCalled()
+  })
+
   it('hard-deletes retained documents before deleting an expired knowledge base', async () => {
     mockChunkedBatchDelete.mockImplementationOnce(
       async (options: {

apps/sim/background/cleanup-soft-deletes.ts

@@ -35,6 +35,7 @@ import type { StorageContext } from '@/lib/uploads'
 import { isUsingCloudStorage, StorageService } from '@/lib/uploads'
 import { allocateUniqueWorkspaceFileName } from '@/lib/uploads/contexts/workspace/workspace-file-manager'
 import { deleteFileMetadata } from '@/lib/uploads/server/metadata'
+import { getWorkspaceFileSize } from '@/lib/uploads/shared/types'
 import { deduplicateWorkflowName } from '@/lib/workflows/utils'
 
 const logger = createLogger('CleanupSoftDeletes')
@@ -113,7 +114,7 @@ async function selectExpiredWorkspaceFiles(
           key: workspaceFiles.key,
           workspaceId: workspaceFiles.workspaceId,
           context: workspaceFiles.context,
-          size: sql<number>`${workspaceFiles.sizeBytes}`.mapWith(Number),
+          sizeBytes: workspaceFiles.sizeBytes,
         })
         .from(workspaceFiles)
         .where(
@@ -134,7 +135,7 @@ async function selectExpiredWorkspaceFiles(
       key: r.key,
       workspaceId: r.workspaceId,
       context: r.context as StorageContext,
-      size: r.size,
+      size: getWorkspaceFileSize(r),
     })),
   }
 }

apps/sim/ee/workspace-forking/lib/copy/storage-quota.test.ts

@@ -49,7 +49,7 @@ import {
 } from '@/ee/workspace-forking/lib/copy/storage-quota'
 import { ForkError } from '@/ee/workspace-forking/lib/lineage/authz'
 
-function makeExecutor(total: number | string) {
+function makeExecutor(total: number | string | null) {
   const execute = vi.fn((_query: unknown) => Promise.resolve([{ total }]))
   return { executor: { execute } as unknown as DbOrTx, execute }
 }
@@ -71,6 +71,8 @@ describe('sumForkCopyBytes', () => {
     const compiled = outerQuery.toSQL()
     expect(compiled.sql).toBe('SELECT (? + ?)::bigint AS total')
     const [fileBytes, kbBytes] = compiled.params
+    expect(fileBytes.toSQL().sql).toContain('count(*) FILTER')
+    expect(fileBytes.toSQL().sql).toContain('IS NULL')
     expect(fileBytes.toSQL().params).toContainEqual({
       type: 'and',
       conditions: [
@@ -101,6 +103,17 @@ describe('sumForkCopyBytes', () => {
     expect(bytes).toBe(1024)
   })
 
+  it('fails closed when a selected workspace file lacks canonical size metadata', async () => {
+    const { executor } = makeExecutor(null)
+
+    await expect(
+      sumForkCopyBytes(executor, 'src-ws', { fileIds: ['wf-missing-size'] })
+    ).rejects.toMatchObject({
+      message: 'Storage calculation is temporarily unavailable',
+      statusCode: 503,
+    })
+  })
+
   it('runs no query for an empty selection', async () => {
     const { executor, execute } = makeExecutor(0)
 

apps/sim/ee/workspace-forking/lib/copy/storage-quota.ts

@@ -47,8 +47,11 @@ export async function sumForkCopyBytes(
   const fileBytes =
     fileSelectors.length === 0
       ? sql<number>`0`
-      : sql<number>`(
-          SELECT coalesce(sum(${workspaceFiles.sizeBytes}), 0)
+      : sql<number | null>`(
+          SELECT CASE
+            WHEN count(*) FILTER (WHERE ${workspaceFiles.sizeBytes} IS NULL) > 0 THEN NULL
+            ELSE coalesce(sum(${workspaceFiles.sizeBytes}), 0)
+          END
           FROM ${workspaceFiles}
           WHERE ${and(
             fileSelectors.length === 1 ? fileSelectors[0] : or(...fileSelectors),
@@ -74,10 +77,13 @@ export async function sumForkCopyBytes(
             isNotNull(document.storageKey)
           )}
         )`
-  const [row] = await executor.execute<{ total: number | string }>(
+  const [row] = await executor.execute<{ total: number | string | null }>(
     sql`SELECT (${fileBytes} + ${kbBytes})::bigint AS total`
   )
-  return Number(row?.total ?? 0)
+  if (row?.total == null) {
+    throw new ForkError('Storage calculation is temporarily unavailable', 503)
+  }
+  return Number(row.total)
 }
 
 type ForkCreationPayerPolicy = Pick<